fix: change Ok to OK
#32259
Merged
fix: change Ok to OK
#32259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
xrkffgg
reviewed
Sep 23, 2021
| @@ -11,7 +11,7 @@ As Alan Cooper states：「Where there is output, let there be input」. This is | |||
|
|
|||
| ## In-Page Editing | |||
|
|
|||
| <img class="preview-img" align="right" alt="Example of click to edit" description="Status 1: Common browsing mode, do not distinguish between editable and non-editable lines；<br>Status 2: On mouse hover, the background is backlit with yellow. A tool tip invites the user to 'Click to edit'；<br>Status 3: Once the user clicks on the title, the form elements 「Input box」, 「Ok」 and 「Cancel」 appear, and the cursor is positioned in the 「input box」." src="https://gw.alipayobjects.com/zos/rmsportal/EXKwsvUkIUNkHBSsOlRi.png"> | |||
| <img class="preview-img" align="right" alt="Example of click to edit" description="Status 1: Common browsing mode, do not distinguish between editable and non-editable lines；<br>Status 2: On mouse hover, the background is backlit with yellow. A tool tip invites the user to 'Click to edit'；<br>Status 3: Once the user clicks on the title, the form elements 「Input box」, 「OK」 and 「Cancel」 appear, and the cursor is positioned in the 「input box」." src="https://gw.alipayobjects.com/zos/rmsportal/EXKwsvUkIUNkHBSsOlRi.png"> | |||
There was a problem hiding this comment.
CI 挂了，你这个不会是 项目搜索 所有的 Ok 进行替换吧。。。。
There was a problem hiding this comment.
我只是修改了文案，怎么会导致test都跑挂呢
There was a problem hiding this comment.
重新跑了一下yarn test:update，更新了snapshot
There was a problem hiding this comment.
其实那几个 Demo ，可以在 md 上 改成 OK ，统一一些
Codecov Report
@@ Coverage Diff @@
## master #32259 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 414 414
Lines 7571 7571
Branches 2125 2125
=========================================
Hits 7571 7571
Continue to review full report at Codecov.
|
|
哈哈哈 本来我还想修来着，老哥够快速的 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #32250
💡 Background and solution
the word
Okis not a formal abbreviations, it needs to be changed toOK.📝 Changelog
Okabbreviation to beOKOk缩写为OK☑️ Self Check before Merge