Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Alert message could be nullable #32057

Merged
merged 2 commits into from
Sep 7, 2021
Merged

fix: Alert message could be nullable #32057

merged 2 commits into from
Sep 7, 2021

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Sep 7, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #32047

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Alert extra dom node when message is undefined.
🇨🇳 Chinese 修复 Alert message 为空时 dom 节点还在的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2021 •
edited
Loading

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2021 •
edited
Loading

Size Change: +10 B (0%)

Total Size: 915 kB

Filename Size Change
./dist/antd-with-locales.min.js 351 kB +5 B (0%)
./dist/antd.min.js 303 kB +5 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/antd.compact.min.css 64.8 kB
./dist/antd.dark.min.css 66.1 kB
./dist/antd.min.css 65 kB
./dist/antd.variable.min.css 65.5 kB

compressed-size-action

@codecov
Copy link

codecov bot commented Sep 7, 2021 •
edited
Loading

Codecov Report

Merging #32057 (6586edf) into master (4af66fb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 6586edf differs from pull request most recent head 4190aad. Consider uploading reports for the commit 4190aad to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #32057   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files         411      411           
  Lines        7560     7562    +2     
  Branches     2112     2114    +2     
=======================================
+ Hits         7557     7559    +2     
  Misses          3        3
Impacted Files Coverage Δ
components/alert/index.tsx 100.00% <100.00%> (ø)
components/list/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4af66fb...4190aad. Read the comment docs.

@afc163 afc163 merged commit 0f47b50 into master Sep 7, 2021
@afc163 afc163 deleted the fix-alert-message branch September 7, 2021 05:07
@zombieJ zombieJ mentioned this pull request Sep 7, 2021
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alert 组件message 为空，有description；不需要设置message，但仍然会占据一定空间
1 participant
@afc163