feat: Table filterMode and filterSearch functions #31809

afc163 · 2021-08-16T10:42:12Z

[中文版模板 / Chinese template]

🤔 This is a ...

🔗 Related issue link

close #30654

💡 Background and solution

Preview url: https://preview-31809-ant-design.surge.sh/components/table-cn/#components-table-demo-filter-in-tree

filterMode: 'tree'

filterSearch: true

📝 Changelog

Language	Changelog
🇺🇸 English	- Table adds `column.filterMode` to support filter in a tree, which could set to `'menu' \| 'tree'`. - Table adds `column.filterSearch` for enable search function in filter dropdown. - Table filter reset button won't close dropdown now. - Tweak Transfer filter search input icon position.
🇨🇳 Chinese	- Table 新增 `column.filterMode` 以支持配置树形筛选菜单，可选值为 `'menu' \| 'tree'`。 - Table 新增 `column.filterSearch` 以支持开启筛选列搜索功能。 - Table 筛选菜单重置按钮现在不再关闭菜单和生效。 - 调整 Transfer 筛选搜索框图标位置，使其和表格筛选搜索框统一。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

Doc is updated/provided or not needed
Demo is updated/provided or not needed
TypeScript definition is updated/provided or not needed
Changelog is provided or not needed

github-actions · 2021-08-16T10:42:26Z

codecov · 2021-08-17T12:29:43Z

Codecov Report

Merging #31809 (d58eae3) into feature (a43e21e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           feature   #31809   +/-   ##
========================================
  Coverage    99.95%   99.96%           
========================================
  Files          409      410    +1     
  Lines         7461     7503   +42     
  Branches      2032     2049   +17     
========================================
+ Hits          7458     7500   +42     
  Misses           3        3

Impacted Files	Coverage Δ
components/locale/default.tsx	`100.00% <ø> (ø)`
components/locale/zh_CN.tsx	`100.00% <ø> (ø)`
components/input/Input.tsx	`100.00% <100.00%> (ø)`
...omponents/table/hooks/useFilter/FilterDropdown.tsx	`100.00% <100.00%> (ø)`
components/table/hooks/useFilter/FilterSearch.tsx	`100.00% <100.00%> (ø)`
components/table/hooks/useFilter/index.tsx	`100.00% <100.00%> (ø)`
components/transfer/search.tsx	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a43e21e...d58eae3. Read the comment docs.

afc163 · 2021-08-19T11:25:24Z

filterMultiple 支持
select 父节点时，key 里面只有一个。需要把这个测试用例跑通：73a578f

搞定，如此简单！f37a517

afc163 · 2021-08-26T01:09:46Z

谁来 review 一下，给个 approve

kerm1it · 2021-08-26T01:28:27Z

提交太多了，没法review😄，直接给 approve？

hengkx · 2021-08-26T01:48:50Z

是的太多了，我看Input 里面也有新增加属性为什么没有拆分出来, 还有htmlSize感觉怪怪的

afc163 · 2021-08-26T01:58:16Z

是的太多了，我看Input 里面也有新增加属性为什么没有拆分出来, 还有htmlSize感觉怪怪的

htmlSize 是解决 Input 最小宽度的问题。不修改的话 Table 筛选菜单里的搜索框最小宽度就太大了。

hengkx · 2021-08-26T02:07:56Z

是的太多了，我看Input 里面也有新增加属性为什么没有拆分出来, 还有htmlSize感觉怪怪的

htmlSize 是解决 Input 最小宽度的问题。不修改的话 Table 筛选菜单里的搜索框最小宽度就太大了。

style width minWidth不能用吗？

kerm1it · 2021-08-26T02:12:02Z

这个是正常的么？

xrkffgg · 2021-08-26T02:28:08Z

rtl 样式有点问题，不过不着急，回头我单改就行

afc163 · 2021-08-27T04:05:00Z

@kerm1it 正常，Transfer 的搜索框样式也统一掉了，所有有结构变化。

components/table/hooks/useFilter/FilterSearch.tsx

components/table/interface.tsx

components/table/hooks/useFilter/FilterDropdown.tsx

…ranch

Co-authored-by: Peach <scdzwyxst@gmail.com>

github-actions · 2021-08-31T14:57:25Z

Size Change: +2.23 kB (0%)

Total Size: 844 kB

Filename	Size	Change
`./dist/antd-with-locales.min.js`	348 kB	+987 B (0%)
`./dist/antd.compact.min.css`	64.8 kB	+87 B (0%)
`./dist/antd.dark.min.css`	66.1 kB	+87 B (0%)
`./dist/antd.min.css`	65 kB	+87 B (0%)
`./dist/antd.min.js`	300 kB	+986 B (0%)

_{compressed-size-action}

.antd-tools.config.js

Veveue · 2022-02-22T02:59:05Z

筛选菜单重置按钮现在不再关闭菜单和生效。这个有没有开关 @afc163

Simoon-F · 2022-04-14T14:35:51Z

filterMode: 'tree' 的搜索可以过滤可以和 menu 一样，只展示符合条件的吗？或者说有什么比较好的方案实现？

afc163 force-pushed the feat-table-filter-tree branch from ef5f232 to dc97a52 Compare August 17, 2021 10:30

afc163 changed the title ~~feat: Table filterMode~~ feat: Table filterMode and filterSearch functions Aug 17, 2021

afc163 marked this pull request as ready for review August 19, 2021 10:00

afc163 requested review from chenshuai2144, zombieJ, 07akioni, kerm1it, rdmclin2, shaodahong, vagusX, xrkffgg and yoyo837 August 23, 2021 03:10

afc163 force-pushed the feat-table-filter-tree branch from 8b67b86 to d0655d1 Compare August 23, 2021 10:51

afc163 requested review from hengkx, Rustin170506, ycjcl868, yesmeck and a team August 25, 2021 05:00

PeachScript reviewed Aug 30, 2021

View reviewed changes

components/table/hooks/useFilter/FilterSearch.tsx Show resolved Hide resolved

components/table/interface.tsx Show resolved Hide resolved

components/table/hooks/useFilter/FilterDropdown.tsx Show resolved Hide resolved

afc163 and others added 11 commits August 31, 2021 22:46

style: update transfer search input style

2cd1d80

perf: improve table perf

74ce339

fix: filterMuiltiple={false}

24ce787

test: add test for selecting

7952fb5

chore: fix table filter selection

5907574

fix lint

ce1e604

remove unused code

1dbe137

fix: style dependencies

29c0f9e

test: turn off bail config for duplidated-package-plugin in feature b…

e91dc59

…ranch

Update components/table/hooks/useFilter/FilterSearch.tsx

2fe7a93

Co-authored-by: Peach <scdzwyxst@gmail.com>

fix locale link

06a6823

afc163 force-pushed the feat-table-filter-tree branch from 6dae4a7 to 06a6823 Compare August 31, 2021 14:46

xrkffgg approved these changes Aug 31, 2021

View reviewed changes

PeachScript approved these changes Aug 31, 2021

View reviewed changes

afc163 commented Sep 1, 2021

View reviewed changes

.antd-tools.config.js Outdated Show resolved Hide resolved

Apply suggestions from code review

06cbfcc

afc163 commented Sep 1, 2021

View reviewed changes

.antd-tools.config.js Outdated Show resolved Hide resolved

Apply suggestions from code review

d58eae3

afc163 merged commit 9c17f94 into feature Sep 1, 2021

afc163 deleted the feat-table-filter-tree branch September 1, 2021 02:49

zombieJ mentioned this pull request Sep 1, 2021

docs: add 4.17.0-alpha.0 changelog #31987

Merged

15 tasks

afc163 mentioned this pull request Oct 13, 2021

Antd组件官网示例自定义筛选Reset没反应 4.17.0-alpha.5版本 #32454

Closed

1 task

afc163 mentioned this pull request Dec 9, 2021

Ant Design Table Component - column search input not resetting after clicking the reset button #33215

Closed

1 task

MadCcc mentioned this pull request Feb 18, 2022

clearFilters is not working on Table component #34109

Closed

1 task

afc163 mentioned this pull request Apr 28, 2022

Adding search field to dropdown filters. #30654

Closed

1 task

tangjinzhou mentioned this pull request May 2, 2022

The reset of the table filter needs to be clicked outside the dropdown area to take effect vueComponent/ant-design-vue#5560

Closed

1 task

awesomeWay mentioned this pull request Jul 1, 2022

筛选菜单重置按钮现在不再关闭菜单和生效。这个有没有开关 @afc163 #36340

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Table filterMode and filterSearch functions #31809

feat: Table filterMode and filterSearch functions #31809

afc163 commented Aug 16, 2021 •

edited

Loading

github-actions bot commented Aug 16, 2021 •

edited

Loading

codecov bot commented Aug 17, 2021 •

edited

Loading

afc163 commented Aug 19, 2021 •

edited

Loading

afc163 commented Aug 26, 2021

kerm1it commented Aug 26, 2021 •

edited

Loading

hengkx commented Aug 26, 2021

afc163 commented Aug 26, 2021

hengkx commented Aug 26, 2021

kerm1it commented Aug 26, 2021 •

edited

Loading

xrkffgg commented Aug 26, 2021

afc163 commented Aug 27, 2021

github-actions bot commented Aug 31, 2021

Veveue commented Feb 22, 2022

Simoon-F commented Apr 14, 2022

feat: Table filterMode and filterSearch functions #31809

feat: Table filterMode and filterSearch functions #31809

Conversation

afc163 commented Aug 16, 2021 • edited Loading

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

☑️ Self Check before Merge

github-actions bot commented Aug 16, 2021 • edited Loading

codecov bot commented Aug 17, 2021 • edited Loading

Codecov Report

afc163 commented Aug 19, 2021 • edited Loading

afc163 commented Aug 26, 2021

kerm1it commented Aug 26, 2021 • edited Loading

hengkx commented Aug 26, 2021

afc163 commented Aug 26, 2021

hengkx commented Aug 26, 2021

kerm1it commented Aug 26, 2021 • edited Loading

xrkffgg commented Aug 26, 2021

afc163 commented Aug 27, 2021

github-actions bot commented Aug 31, 2021

Veveue commented Feb 22, 2022

Simoon-F commented Apr 14, 2022

afc163 commented Aug 16, 2021 •

edited

Loading

github-actions bot commented Aug 16, 2021 •

edited

Loading

codecov bot commented Aug 17, 2021 •

edited

Loading

afc163 commented Aug 19, 2021 •

edited

Loading

kerm1it commented Aug 26, 2021 •

edited

Loading

kerm1it commented Aug 26, 2021 •

edited

Loading