Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification support maxCount #31807

Merged
merged 5 commits into from
Aug 17, 2021
Merged

Notification support maxCount #31807

merged 5 commits into from
Aug 17, 2021

Conversation

binyellow
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Notification support maxCount
🇨🇳 Chinese Notification支持maxCount属性以限制最大显示数

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

Prepare preview

@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #31807 (343390d) into feature (653e4ec) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #31807      +/-   ##
===========================================
- Coverage   100.00%   99.96%   -0.04%     
===========================================
  Files          397      407      +10     
  Lines         7591     7615      +24     
  Branches      2078     2084       +6     
===========================================
+ Hits          7591     7612      +21     
- Misses           0        3       +3     
Impacted Files Coverage Δ
components/notification/index.tsx 100.00% <100.00%> (ø)
components/form/hooks/useFrameState.ts 95.65% <0.00%> (-4.35%) ⬇️
components/form/ErrorList.tsx 96.42% <0.00%> (-3.58%) ⬇️
components/form/FormItem.tsx 99.19% <0.00%> (-0.81%) ⬇️
components/menu/index.tsx 100.00% <0.00%> (ø)
components/modal/index.tsx 100.00% <0.00%> (ø)
components/_util/motion.tsx 100.00% <0.00%> (ø)
components/drawer/index.tsx 100.00% <0.00%> (ø)
components/form/context.tsx 100.00% <0.00%> (ø)
components/avatar/avatar.tsx 100.00% <0.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 653e4ec...343390d. Read the comment docs.

@afc163 afc163 merged commit bbb7e96 into ant-design:feature Aug 17, 2021
@zombieJ zombieJ mentioned this pull request Sep 1, 2021
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants