Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow DatePicker/RangePicker Icon Overrides #31703

Merged
merged 4 commits into from
Aug 23, 2021

Conversation

Oreoz
Copy link
Contributor

@Oreoz Oreoz commented Aug 6, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Our current antd use case requires the default nextIcon, prevIcon, superNextIcon and superPrevIcon to be modified. That is currently not possible.

💡 Background and solution

Solution: Hoist the default icons and allow for overrides.

📝 Changelog

Language Changelog
🇺🇸 English DatePicker and RangePicker now support nextIcon, prevIcon, superNextIcon and superPrevIcon
🇨🇳 Chinese DatePickerRangePicker 现在支持 nextIconprevIconsuperNextIconsuperPrevIcon

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@Oreoz Oreoz changed the title WIP: Allow DatePicker Icon Overrides feat: Allow DatePicker Icon Overrides Aug 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2021

@Oreoz Oreoz changed the title feat: Allow DatePicker Icon Overrides feat: Allow DatePicker/RangePicker Icon Overrides Aug 6, 2021
@Oreoz
Copy link
Contributor Author

Oreoz commented Aug 6, 2021

I'm not a Chinese speaker so it's all from Google Translate -- I'll need someone to double check it.

@codecov
Copy link

codecov bot commented Aug 8, 2021

Codecov Report

Merging #31703 (763d19b) into feature (f605ca8) will not change coverage.
The diff coverage is n/a.

❗ Current head 763d19b differs from pull request most recent head 6055124. Consider uploading reports for the commit 6055124 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #31703   +/-   ##
========================================
  Coverage    99.96%   99.96%           
========================================
  Files          407      407           
  Lines         7609     7609           
  Branches      2080     2080           
========================================
  Hits          7606     7606           
  Misses           3        3           
Impacted Files Coverage Δ
...date-picker/generatePicker/generateRangePicker.tsx 100.00% <ø> (ø)
...ate-picker/generatePicker/generateSinglePicker.tsx 100.00% <ø> (ø)
components/date-picker/generatePicker/index.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f605ca8...6055124. Read the comment docs.

@afc163 afc163 merged commit 1cd6948 into ant-design:feature Aug 23, 2021
@zombieJ zombieJ mentioned this pull request Sep 1, 2021
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants