Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Badge count style when customize color #31617

Merged
merged 4 commits into from
Aug 2, 2021
Merged

fix: Badge count style when customize color #31617

merged 4 commits into from
Aug 2, 2021

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Aug 2, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #31591 Thx @eokoneyo
close #31590

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Badge not showing count when customize color prop.
🇨🇳 Chinese 修复 Badge 设置自定义 color 不显示数字的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2021

@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #31617 (f20a1d3) into master (38e9d30) will not change coverage.
The diff coverage is 100.00%.

❗ Current head f20a1d3 differs from pull request most recent head 65842b2. Consider uploading reports for the commit 65842b2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master    #31617   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines         7587      7586    -1     
  Branches      2077      2075    -2     
=========================================
- Hits          7587      7586    -1     
Impacted Files Coverage Δ
components/badge/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38e9d30...65842b2. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2021

Size Change: -7 B (0%)

Total Size: 836 kB

Filename Size Change
./dist/antd-with-locales.min.js 343 kB -3 B (0%)
./dist/antd.min.js 299 kB -4 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/antd.compact.min.css 64.4 kB
./dist/antd.dark.min.css 65.7 kB
./dist/antd.min.css 64.5 kB

compressed-size-action

@afc163 afc163 merged commit 06dff86 into master Aug 2, 2021
@afc163 afc163 deleted the fix-badge-dot branch August 2, 2021 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Badge shows dot instead of count when count value is provided if custom colour is set
1 participant