Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tabs tabBarGutter wrong style #31469

Merged
merged 3 commits into from
Jul 22, 2021
Merged

fix: Tabs tabBarGutter wrong style #31469

merged 3 commits into from
Jul 22, 2021

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jul 21, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #31462

react-component/tabs#406

💡 Background and solution

  1. 第一个 Tab 不应该有间距。Tabs 的tabBarGutter 设置后,第一个TabPane也会margin-left。导致第一个TabPane位置跟下面的内容不对齐。这是符合预期的吗? #31462
  2. 新增按钮的间距丢失了。
  3. RTL 模式下间距丢失。

图片

📝 Changelog

Language Changelog
🇺🇸 English Fix Tabs tabBarGutter abnormal behaviors.
🇨🇳 Chinese 修复 Tabs tabBarGutter 的一些异常行为。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

afc163 added 2 commits July 21, 2021 18:08
1. first tab should not have gutter
2. add button lost gutter
3. rtl issue

close #31462
@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2021

@github-actions
Copy link
Contributor

Size Change: +185 B (0%)

Total Size: 832 kB

Filename Size Change
./dist/antd-with-locales.min.js 341 kB +46 B (0%)
./dist/antd.compact.min.css 64.3 kB +29 B (0%)
./dist/antd.dark.min.css 65.6 kB +27 B (0%)
./dist/antd.min.css 64.5 kB +25 B (0%)
./dist/antd.min.js 297 kB +58 B (0%)

compressed-size-action

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #31469 (a01e123) into master (7f89931) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #31469   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines         7582      7582           
  Branches      2136      2136           
=========================================
  Hits          7582      7582           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f89931...a01e123. Read the comment docs.

@afc163 afc163 merged commit 568a999 into master Jul 22, 2021
@afc163 afc163 deleted the fix-tabBarGutter branch July 22, 2021 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant