Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Typography.Text ellipsis bug #31449

Merged
merged 8 commits into from
Jul 20, 2021
Merged

fix: Typography.Text ellipsis bug #31449

merged 8 commits into from
Jul 20, 2021

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jul 19, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #19219
close #30777
close #28599
close #15581
close #30797
close #30426
close #28547
close #28460
close ant-design/pro-components#1405
close ant-design/pro-components#3228
close ant-design/pro-components#2422

💡 Background and solution

图片

📝 Changelog

Language Changelog
🇺🇸 English Fix Typography ellipsis calculation bug when browser zoomed.
🇨🇳 Chinese 修复 Typography ellipsis 在屏幕放大缩小时计算错误的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163 afc163 force-pushed the fix-text-ellipsis branch from 817dff8 to 7d51c4d Compare July 19, 2021 14:50
@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2021

@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2021

Size Change: +204 B (0%)

Total Size: 832 kB

Filename Size Change
./dist/antd-with-locales.min.js 341 kB +110 B (0%)
./dist/antd.compact.min.css 64.3 kB +1 B (0%)
./dist/antd.dark.min.css 65.6 kB +2 B (0%)
./dist/antd.min.css 64.5 kB +2 B (0%)
./dist/antd.min.js 297 kB +89 B (0%)

compressed-size-action

@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #31449 (68a5dfb) into master (d1dc0eb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #31449   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines         7568      7582   +14     
  Branches      2135      2136    +1     
=========================================
+ Hits          7568      7582   +14     
Impacted Files Coverage Δ
components/typography/util.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1dc0eb...68a5dfb. Read the comment docs.

@afc163 afc163 marked this pull request as ready for review July 20, 2021 05:28
@afc163 afc163 merged commit 79825fd into master Jul 20, 2021
@afc163 afc163 deleted the fix-text-ellipsis branch July 20, 2021 05:51
@afc163 afc163 mentioned this pull request Oct 15, 2021
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment