Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Select background error #31430

Merged
merged 4 commits into from
Jul 16, 2021
Merged

fix: Select background error #31430

merged 4 commits into from
Jul 16, 2021

Conversation

DerrickTel
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Select background in disabled.
🇨🇳 Chinese 修复 Select 组件 disabled 时背景颜色错误的问题.

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2021 •
edited
Loading

@codecov
Copy link

codecov bot commented Jul 16, 2021 •
edited
Loading

Codecov Report

Merging #31430 (6cd41ed) into master (7f8e177) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #31430   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines         7568      7568           
  Branches      2135      2135           
=========================================
  Hits          7568      7568

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f8e177...6cd41ed. Read the comment docs.

@xrkffgg
Copy link
Member

xrkffgg commented Jul 16, 2021

截个图 看下效果

@DerrickTel
Copy link
Contributor Author

截个图 看下效果

image

@yoyo837
Copy link
Contributor

yoyo837 commented Jul 16, 2021

可以错误的和修复后的都给个参考

@DerrickTel
Copy link
Contributor Author

可以错误的和修复后的都给个参考

修改前
image
修改后
image

@afc163 afc163 merged commit bca4078 into ant-design:master Jul 16, 2021
@PeachScript PeachScript mentioned this pull request Jul 18, 2021
Merged
15 tasks
@DerrickTel DerrickTel deleted the fix-select-disabled-color branch October 13, 2021 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrkffgg xrkffgg xrkffgg left review comments

@yoyo837 yoyo837 yoyo837 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DerrickTel @xrkffgg @yoyo837 @afc163