Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: input-number wrapper's border triggers hover unexpectedly #31300

Merged
merged 1 commit into from
Jul 8, 2021
Merged

fix: input-number wrapper's border triggers hover unexpectedly #31300

merged 1 commit into from
Jul 8, 2021

Conversation

diyews
Copy link
Contributor

@diyews diyews commented Jul 7, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

number-input
Hover over border-left of .ant-input-number-handler-wrap, then handlers will be styled by height: 40%, and no one has the style height: 60%, causing this issue.

Solution: move border from .ant-input-number-handler-wrap into .ant-input-number-handler

📝 Changelog

Language Changelog
🇺🇸 English Fix InputNumber border and interactive handler not matched.
🇨🇳 Chinese 修复 InputNumber 边框和交互范围不匹配的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2021

@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #31300 (3baddc7) into master (0984bae) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #31300   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines         7570      7570           
  Branches      2134      2134           
=========================================
  Hits          7570      7570           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0984bae...3baddc7. Read the comment docs.

@afc163 afc163 merged commit e9666f8 into ant-design:master Jul 8, 2021
@diyews diyews deleted the fix-input-number-border branch July 8, 2021 14:47
@zombieJ zombieJ mentioned this pull request Jul 12, 2021
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants