Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: transfer support locale.notFoundContent as array #31088

Merged
merged 2 commits into from
Jun 23, 2021
Merged

feat: transfer support locale.notFoundContent as array #31088

merged 2 commits into from
Jun 23, 2021

Conversation

wwyx778
Copy link
Contributor

@wwyx778 wwyx778 commented Jun 22, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Close: #31034

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English The Transfer supports locale.notFoundContent icoming array
🇨🇳 Chinese 穿梭框支持 locale.notFoundContent 传入数组

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2021 •
edited
Loading

@codecov
Copy link

codecov bot commented Jun 22, 2021 •
edited
Loading

Codecov Report

Merging #31088 (7c86e11) into feature (ba8eac0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 7c86e11 differs from pull request most recent head 960dd3c. Consider uploading reports for the commit 960dd3c to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #31088   +/-   ##
========================================
  Coverage    99.96%   99.96%           
========================================
  Files          397      397           
  Lines         7561     7564    +3     
  Branches      2076     2078    +2     
========================================
+ Hits          7558     7561    +3     
  Misses           3        3
Impacted Files Coverage Δ
components/transfer/index.tsx 100.00% <ø> (ø)
components/transfer/list.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba8eac0...960dd3c. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Jun 22, 2021

Could you add a test case?

@wwyx778
Copy link
Contributor Author

wwyx778 commented Jun 23, 2021

Could you add a test case?

sry, I will add soon.

@afc163 afc163 merged commit a350421 into ant-design:feature Jun 23, 2021
@zombieJ zombieJ mentioned this pull request Sep 1, 2021
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wwyx778 @afc163