Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: InputNumber formatter support additional info #31030

Merged
merged 2 commits into from
Jun 17, 2021
Merged

feat: InputNumber formatter support additional info #31030

merged 2 commits into from
Jun 17, 2021

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jun 17, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #30455

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English InputNumber formatter support additional param to check if current input is user typing.
🇨🇳 Chinese InputNumber formatter 支持额外参数用以检测当前变更是否为用户输入。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2021 •
edited
Loading

@codecov
Copy link

codecov bot commented Jun 17, 2021 •
edited
Loading

Codecov Report

Merging #31030 (258e7a5) into feature (f45f735) will increase coverage by 1.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #31030      +/-   ##
===========================================
+ Coverage    98.81%   99.96%   +1.14%     
===========================================
  Files          363      397      +34     
  Lines         7280     7561     +281     
  Branches      1967     2076     +109     
===========================================
+ Hits          7194     7558     +364     
+ Misses          86        3      -83
Impacted Files Coverage Δ
components/_util/easings.ts 100.00% <ø> (ø)
components/_util/raf.ts 100.00% <ø> (ø)
components/_util/scrollTo.ts 100.00% <ø> (ø)
components/_util/type.ts 100.00% <ø> (ø)
components/calendar/generateCalendar.tsx 100.00% <ø> (+1.33%) ⬆️
components/calendar/index.tsx 100.00% <ø> (ø)
components/card/Grid.tsx 100.00% <ø> (ø)
components/_util/ActionButton.tsx 100.00% <100.00%> (ø)
components/_util/getScroll.tsx 100.00% <100.00%> (ø)
components/_util/hooks/useFlexGapSupport.ts 100.00% <100.00%> (ø)
... and 243 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efb970c...258e7a5. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2021 •
edited
Loading

Size Change: +201 B (0%)

Total Size: 832 kB

Filename Size Change
./dist/antd-with-locales.min.js 341 kB +143 B (0%)
./dist/antd.min.js 298 kB +58 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 63.9 kB 0 B
./dist/antd.dark.min.css 65.2 kB 0 B
./dist/antd.min.css 64.1 kB 0 B

compressed-size-action

@zombieJ zombieJ merged commit ba8eac0 into feature Jun 17, 2021
@zombieJ zombieJ deleted the input-number branch June 17, 2021 13:45
@zombieJ zombieJ mentioned this pull request Sep 1, 2021
Merged
15 tasks
@yangjunhan yangjunhan mentioned this pull request Jan 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@07akioni 07akioni 07akioni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zombieJ @07akioni