feat: Form rule support warningOnly that not block form submit
#30829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
Size Change: +429 B (0%) Total Size: 831 kB
|
yoyo837
reviewed
Jun 3, 2021
components/_util/motion.tsx
Outdated
| @@ -3,7 +3,17 @@ import { MotionEvent } from 'rc-motion/lib/interface'; | |||
|
|
|||
| // ================== Collapse Motion ================== | |||
| const getCollapsedHeight: MotionEventHandler = () => ({ height: 0, opacity: 0 }); | |||
| const getRealHeight: MotionEventHandler = node => ({ height: node.scrollHeight, opacity: 1 }); | |||
| const getRealHeight: MotionEventHandler = node => { | |||
| const { overflow } = node.style; | |||
There was a problem hiding this comment.
这会不会有overflow-x, overflow-y 的属性？
There was a problem hiding this comment.
这个 overflow 只做覆盖还原用，不在乎它的值的~
Codecov Report
@@ Coverage Diff @@
## feature #30829 +/- ##
===========================================
+ Coverage 98.81% 99.96% +1.14%
===========================================
Files 363 397 +34
Lines 7280 7523 +243
Branches 1967 2105 +138
===========================================
+ Hits 7194 7520 +326
+ Misses 86 3 -83
Continue to review full report at Codecov.
|
zombieJ
changed the title
rule support warningOnly that not block form submitrule support warningOnly that not block form submit
|
TS 校验那个需要 antd 发包才能对上，先不用管 |
hengkx
approved these changes
Jun 4, 2021
xrkffgg
approved these changes
Jun 4, 2021
|
ci 挂了 |
|
afc163
added a commit
that referenced
this pull request
Jun 7, 2021
19 tasks
19 tasks
zombieJ
pushed a commit
that referenced
this pull request
Jun 7, 2021
|
测试覆盖率掉了 3 行。 |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
https://preview-30829-ant-design.surge.sh/components/form-cn/#components-form-demo-warning-only
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge