Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Table column title styles #30799

Merged
merged 2 commits into from
Jun 1, 2021
Merged

fix: Table column title styles #30799

merged 2 commits into from
Jun 1, 2021

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jun 1, 2021 •
edited
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #27959
close #30787

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Table column which contains filters or sorters cannot work with onClick and ellipsis property.
🇨🇳 Chinese 修复 Table 列筛选和排序时 column.title 设置 onClick 和 ellipsis 无效的问题

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2021 •
edited
Loading

@codecov
Copy link

codecov bot commented Jun 1, 2021 •
edited
Loading

Codecov Report

Merging #30799 (982f6ca) into master (9f0dbf2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #30799   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines         7571      7543   -28     
  Branches      2123      2113   -10     
=========================================
- Hits          7571      7543   -28
Impacted Files Coverage Δ
components/tree-select/index.tsx 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f0dbf2...982f6ca. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2021

Size Change: +49 B (0%)

Total Size: 830 kB

Filename Size Change
./dist/antd.compact.min.css 64 kB +18 B (0%)
./dist/antd.dark.min.css 65.3 kB +16 B (0%)
./dist/antd.min.css 64.2 kB +15 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 340 kB 0 B
./dist/antd.min.js 297 kB 0 B

compressed-size-action

@afc163 afc163 merged commit 01d126b into master Jun 1, 2021
@afc163 afc163 deleted the fix-table-head branch June 1, 2021 03:36
@zombieJ zombieJ mentioned this pull request Jun 7, 2021
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@afc163