fix: fix incorrect type declarations #30776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #30776 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 397 397
Lines 7546 7546
Branches 2113 2113
=========================================
Hits 7546 7546
Continue to review full report at Codecov.
|
|
可以配置个 strict 模式的 action，每次提交的类型错误数量不能多余上一次。 |
没太懂你这句话什么意思呢？ @yesmeck |
|
我意思在 CI 里用 strict 模式跑一次 tsc，跟上一次 commit 的类型错误数量做次对比，这样可以避免引入新的类型错误。 |
他可能不是留言给你的。 |
|
看一下 CI。 |
qqabcv520
changed the title
|
CI 要怎么做？我没太明白 |
|
CI 现在是通过的 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[English Template / 英文模板]
🤔 这个变动的性质是？
🔗 相关 Issue
#14445
💡 需求背景和解决方案
开启 tsconfig 的 strictMode，因为一次性需要修改的类型声明太多，所以先分批修复提交，最后再将 tsconfig.json 的
strict: true开启。📝 更新日志
☑️ 请求合并前的自查清单