Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config-provider): support dynamic prefixCls #30625

Merged
merged 1 commit into from
May 24, 2021
Merged

Conversation

kerm1it
Copy link
Member

@kerm1it kerm1it commented May 22, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #30612

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English ConfigProvider support dynamic prefixCls.
🇨🇳 Chinese ConfigProvider 支持动态 prefixCls

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@codecov
Copy link

codecov bot commented May 22, 2021

Codecov Report

Merging #30625 (54f0dea) into master (e021147) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #30625   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines         7520      7520           
  Branches      2102      2102           
=========================================
  Hits          7520      7520           
Impacted Files Coverage Δ
components/config-provider/index.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e021147...54f0dea. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2021

@github-actions
Copy link
Contributor

Size Change: +6 B (0%)

Total Size: 832 kB

Filename Size Change
./dist/antd-with-locales.min.js 341 kB +3 B (0%)
./dist/antd.min.js 298 kB +3 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 63.8 kB 0 B
./dist/antd.dark.min.css 65.1 kB 0 B
./dist/antd.min.css 63.9 kB 0 B

compressed-size-action

@kerm1it
Copy link
Member Author

kerm1it commented May 22, 2021

改的时候发现了一个问题,iconPrefixCls 应该也是支持和动态化的,发现并没有生效。

#29045 之前由于这个改动导致用的 Context 是从 lib 目录导入的,但是一般都是从 es 目录导入,所以 导致 iconPrefixCls 失效。

@kerm1it kerm1it requested a review from zombieJ May 24, 2021 03:16
@afc163 afc163 merged commit 9275866 into master May 24, 2021
@afc163 afc163 deleted the dynamic-prefixcls branch May 24, 2021 03:46
afc163 added a commit that referenced this pull request May 24, 2021
* docs(:sparkles:): release 4.15.6 (#30562)

* fix(Collapse): end motion when set activeKey while hiding (#30555)

* docs: update changelog

* fix: Typography ellipsis flush when contain suffix (#30582)

* fix: Typography ellipsis flush when contain suffix

* update snapshot

* fix Text default rows

* fix Text default rows

* style: refactor Collapse arrow style (#30586)

close #30585

* fix: nested Table margin inside table with fixed columns (#30587)

close #30564

* fix: useNotification className should work (#30588)

close #30576

* fix: Space missing TS def (#30590)

* docs: Update Transfer asnyc table demo
close #30350

* fix: Anchor should trigger onChange when have getCurrentAnchor (#30601)

* fix: Anchor should trigger onChange when have getCurrentAnchor

close #30584

* test: add test case

* chore: Thanks @yesmeck & @ycjcl868 (#30618)

* chore(config-provider): support dynamic prefixCls (#30625)

* feat: improve Table filter and sorter position

* fix: edge cases of th border

* fix lint

* style: apply new design

* fix css detail

* fix stylelint

* fix css error

* style: sorter icon hover color

* fix test cases

* update snapshot

* fix th padding

* fix calc

Co-authored-by: JuFeng Zhang <zjffun@gmail.com>
Co-authored-by: 二货机器人 <smith3816@gmail.com>
Co-authored-by: Kermit <kermitlx@outlook.com>
Co-authored-by: chenshuai2144 <qixian.cs@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setState 修改 ConfigProvider 的 prefixCls 内部组件 class 前缀未变化
2 participants