Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Updated hindi locale with missing messages. #30541

Merged
merged 2 commits into from
May 18, 2021
Merged

fix: Updated hindi locale with missing messages. #30541

merged 2 commits into from
May 18, 2021

Conversation

jaideepghosh
Copy link
Contributor

@jaideepghosh jaideepghosh commented May 16, 2021 •
edited
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Updated hindi locale with missing messages.

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@jaideepghosh
Copy link
Contributor Author

@afc163 I'm not sure why the above checks are failing. FYI, I've added hindi translations. Please review the PR and let me know if any change is needed.

@afc163
Copy link
Member

afc163 commented May 16, 2021

@jaideepghosh https://www.githubstatus.com/

@yoyo837
Copy link
Contributor

yoyo837 commented May 16, 2021

Maybe adding the issue template should create another PR.

@jaideepghosh
Copy link
Contributor Author

Thanks @yoyo837 Reverted the issue template change from this PR.
I've created a new PR 30542 for the Issue Template.

@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2021 •
edited
Loading

@yoyo837 yoyo837 mentioned this pull request May 17, 2021
Open
69 tasks
@yoyo837
Copy link
Contributor

yoyo837 commented May 17, 2021 •
edited
Loading

ref: #23369

@yoyo837
Copy link
Contributor

yoyo837 commented May 17, 2021

Please update snapshot.

@jaideepghosh
Copy link
Contributor Author

Hey @yoyo837
What do you mean by Please update snapshot.
I'm not sure about this process.

@yoyo837
Copy link
Contributor

yoyo837 commented May 17, 2021

Pls run code npm run test -- -u and push all changes.

@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #30541 (34c618a) into master (acbeb0b) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 34c618a differs from pull request most recent head f663ffc. Consider uploading reports for the commit f663ffc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##            master    #30541    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          398       397     -1     
  Lines         7949      7521   -428     
  Branches      2214      2049   -165     
==========================================
- Hits          7949      7521   -428
Impacted Files Coverage Δ
components/date-picker/locale/hi_IN.tsx 100.00% <ø> (ø)
components/locale/pt_BR.tsx 100.00% <ø> (ø)
components/time-picker/locale/hi_IN.tsx 100.00% <ø> (ø)
components/locale/hi_IN.tsx 100.00% <100.00%> (ø)
components/menu/index.tsx 100.00% <0.00%> (ø)
components/space/Item.tsx 100.00% <0.00%> (ø)
components/radio/group.tsx 100.00% <0.00%> (ø)
components/space/index.tsx 100.00% <0.00%> (ø)
components/layout/Sider.tsx 100.00% <0.00%> (ø)
components/locale/nl_BE.tsx 100.00% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acbeb0b...f663ffc. Read the comment docs.

yoyo837
yoyo837 reviewed May 17, 2021
View reviewed changes
components/progress/__tests__/__snapshots__/demo.test.js.snap
@@ -849,7 +849,7 @@ Array [
stroke="url(#ant-progress-gradient-13)"
stroke-linecap="round"
stroke-width="6"
style="stroke:[object Object];stroke-dasharray:295.3097094374406px 295.3097094374406px;stroke-dashoffset:-0px;transition:stroke-dashoffset .3s ease 0s, stroke-dasharray .3s ease 0s, stroke .3s, stroke-width .06s ease .3s, opacity .3s ease 0s"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some other commits are mixed in, please wait for #30556 to be merged, and then rebase this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoyo837 Please check now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have not do rebase.

@afc163 afc163 merged commit 599a8f8 into ant-design:master May 18, 2021
@xrkffgg xrkffgg mentioned this pull request May 18, 2021
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoyo837 yoyo837 yoyo837 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaideepghosh @afc163 @yoyo837