Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: fix Rate focused style #30451

Merged
merged 2 commits into from
May 10, 2021
Merged

style: fix Rate focused style #30451

merged 2 commits into from
May 10, 2021

Conversation

afc163
Copy link
Member

@afc163 afc163 commented May 9, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #30449

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Optimize Rate focus behavior from :focus to :focus-visible.
🇨🇳 Chinese 优化 Rate 聚焦行为从 :focus 为 :focus-visible。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2021 •
edited
Loading

@codecov
Copy link

codecov bot commented May 9, 2021 •
edited
Loading

Codecov Report

Merging #30451 (fc35cbd) into master (8a599a0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #30451   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines         7514      7580   +66     
  Branches      2048      2066   +18     
=========================================
+ Hits          7514      7580   +66
Impacted Files Coverage Δ
components/upload/Upload.tsx 100.00% <0.00%> (ø)
components/dropdown/dropdown-button.tsx 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a599a0...fc35cbd. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2021 •
edited
Loading

Size Change: +73 B (0%)

Total Size: 831 kB

Filename Size Change
./dist/antd-with-locales.min.js 340 kB +20 B (0%)
./dist/antd.compact.min.css 64 kB +11 B (0%)
./dist/antd.dark.min.css 65.2 kB +9 B (0%)
./dist/antd.min.css 64 kB +10 B (0%)
./dist/antd.min.js 298 kB +23 B (0%)

compressed-size-action

@xrkffgg xrkffgg marked this pull request as draft May 10, 2021 01:39
@xrkffgg
Copy link
Member

xrkffgg commented May 10, 2021

测试一个东西

@xrkffgg xrkffgg marked this pull request as ready for review May 10, 2021 01:46
@afc163 @xrkffgg
Apply suggestions from code review
fc35cbd 
Co-authored-by: xrkffgg <xrkffgg@gmail.com>
@afc163 afc163 mentioned this pull request May 10, 2021
Merged
@afc163 afc163 merged commit 7e8075b into master May 10, 2021
@afc163 afc163 deleted the fix-rate-transition branch May 10, 2021 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrkffgg xrkffgg xrkffgg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rate element: Remove hover effect when leaving with mouse
2 participants
@afc163 @xrkffgg