Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(upload): beforeUpload type definition #30351

Merged
merged 3 commits into from
Apr 30, 2021
Merged

fix(upload): beforeUpload type definition #30351

merged 3 commits into from
Apr 30, 2021

Conversation

kerm1it
Copy link
Member

@kerm1it kerm1it commented Apr 29, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #30347

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Upload type definition of beforeUpload.
🇨🇳 Chinese 修复上传组件 beforeUpload 类型声明。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2021 •
edited
Loading

@kerm1it kerm1it requested review from afc163 and zombieJ April 29, 2021 06:36
@codecov
Copy link

codecov bot commented Apr 29, 2021 •
edited
Loading

Codecov Report

Merging #30351 (3a7314d) into master (ab83346) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #30351   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines         7522      7590   +68     
  Branches      2105      2141   +36     
=========================================
+ Hits          7522      7590   +68
Impacted Files Coverage Δ
components/typography/Base.tsx 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab83346...3a7314d. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2021 •
edited
Loading

Size Change: +1 B (0%)

Total Size: 830 kB

Filename Size Change
./dist/antd-with-locales.min.js 339 kB -1 B (0%)
./dist/antd.min.js 298 kB +2 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 63.9 kB 0 B
./dist/antd.dark.min.css 65.2 kB 0 B
./dist/antd.min.css 63.9 kB 0 B

compressed-size-action

@afc163 afc163 merged commit dd88e30 into master Apr 30, 2021
@afc163 afc163 deleted the fix-upload-ts branch April 30, 2021 00:59
@zombieJ zombieJ mentioned this pull request Apr 30, 2021
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 left review comments

@zombieJ zombieJ Awaiting requested review from zombieJ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

beforeUpload return type isn't allowing LIST_IGNORE in promise
2 participants
@kerm1it @afc163