Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upload): UploadFile type definition #30343

Merged
merged 1 commit into from
Apr 28, 2021
Merged

fix(upload): UploadFile type definition #30343

merged 1 commit into from
Apr 28, 2021

Conversation

kerm1it
Copy link
Member

@kerm1it kerm1it commented Apr 28, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #30269

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Upload type definition.
🇨🇳 Chinese 修复上传组件类型声明。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2021

@kerm1it kerm1it requested review from zombieJ and afc163 April 28, 2021 12:24
@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #30343 (7eba2fd) into master (fa80ae5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #30343   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines         7522      7522           
  Branches      2105      2105           
=========================================
  Hits          7522      7522           
Impacted Files Coverage Δ
components/upload/UploadList/index.tsx 100.00% <100.00%> (ø)
components/upload/utils.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa80ae5...7eba2fd. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2021

Size Change: 0 B

Total Size: 830 kB

ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 339 kB 0 B
./dist/antd.compact.min.css 63.9 kB 0 B
./dist/antd.dark.min.css 65.2 kB 0 B
./dist/antd.min.css 63.9 kB 0 B
./dist/antd.min.js 298 kB 0 B

compressed-size-action

@afc163
Copy link
Member

afc163 commented Apr 28, 2021

@kerm1it
Copy link
Member Author

kerm1it commented Apr 28, 2021

稍等,我 rebase 一下

@afc163 afc163 merged commit 4ccbf1f into master Apr 28, 2021
@afc163 afc163 deleted the fix-upload-ts branch April 28, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UploadFile typescript definition and 'originFileObj'
2 participants