Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(upload): should work correctly when url of file is null #30215

Merged
merged 2 commits into from
Apr 20, 2021
Merged

fix(upload): should work correctly when url of file is null #30215

merged 2 commits into from
Apr 20, 2021

Conversation

kerm1it
Copy link
Member

@kerm1it kerm1it commented Apr 19, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #30062

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Upload appear errors when url of file is null.
🇨🇳 Chinese 修复 Upload 当文件 url 为 null 时渲染出错问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2021 •
edited
Loading

@kerm1it kerm1it requested review from afc163 and zombieJ April 19, 2021 13:12
@codecov
Copy link

codecov bot commented Apr 19, 2021 •
edited
Loading

Codecov Report

Merging #30215 (6252130) into master (7975c33) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 6252130 differs from pull request most recent head 70cb3e5. Consider uploading reports for the commit 70cb3e5 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #30215      +/-   ##
===========================================
+ Coverage   99.97%   100.00%   +0.02%     
===========================================
  Files         398       397       -1     
  Lines        7565      7524      -41     
  Branches     2127      2107      -20     
===========================================
- Hits         7563      7524      -39     
+ Misses          2         0       -2
Impacted Files Coverage Δ
components/upload/utils.tsx 100.00% <100.00%> (ø)
components/space/Item.tsx 100.00% <0.00%> (ø)
components/page-header/index.tsx 100.00% <0.00%> (ø)
components/_util/hooks/useFlexGapSupport.ts
components/space/index.tsx 100.00% <0.00%> (+4.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7975c33...70cb3e5. Read the comment docs.

@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 829 kB

ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 339 kB 0 B
./dist/antd.compact.min.css 63.8 kB 0 B
./dist/antd.dark.min.css 65 kB 0 B
./dist/antd.min.css 63.8 kB 0 B
./dist/antd.min.js 298 kB 0 B

compressed-size-action

@zombieJ zombieJ merged commit 1f1aa86 into master Apr 20, 2021
@zombieJ zombieJ deleted the fix-upload branch April 20, 2021 01:58
@xrkffgg xrkffgg mentioned this pull request Apr 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 Awaiting requested review from afc163

@zombieJ zombieJ Awaiting requested review from zombieJ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upload组件中fileList中url为null时，页面会报错
2 participants
@kerm1it @zombieJ