Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(upload): beforeUpload return type modification #30213

Merged
merged 1 commit into from
Apr 20, 2021
Merged

fix(upload): beforeUpload return type modification #30213

merged 1 commit into from
Apr 20, 2021

Conversation

hello-chinese
Copy link
Contributor

@hello-chinese hello-chinese commented Apr 19, 2021 •
edited by kerm1it
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Upload type definition of beforeUpload.
🇨🇳 Chinese 修复 Upload 组件 beforeUpload 类型声明。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2021 •
edited
Loading

@codecov
Copy link

codecov bot commented Apr 19, 2021 •
edited
Loading

Codecov Report

Merging #30213 (21ad679) into master (7975c33) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #30213      +/-   ##
===========================================
+ Coverage   99.97%   100.00%   +0.02%     
===========================================
  Files         398       397       -1     
  Lines        7565      7524      -41     
  Branches     2127      2107      -20     
===========================================
- Hits         7563      7524      -39     
+ Misses          2         0       -2
Impacted Files Coverage Δ
components/space/Item.tsx 100.00% <0.00%> (ø)
components/page-header/index.tsx 100.00% <0.00%> (ø)
components/_util/hooks/useFlexGapSupport.ts
components/space/index.tsx 100.00% <0.00%> (+4.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7975c33...21ad679. Read the comment docs.

@afc163 afc163 requested a review from kerm1it April 20, 2021 08:58
@kerm1it
Copy link
Member

kerm1it commented Apr 20, 2021

ref: #30188

@yoyo837
Copy link
Contributor

yoyo837 commented Apr 20, 2021

changelog 有点不解其意，能重新写一下背景吗？是补充#30188？

@kerm1it
Copy link
Member

kerm1it commented Apr 20, 2021

changelog 有点不解其意，能重新写一下背景吗？是补充#30188？

是的，上次没改彻底。

@kerm1it kerm1it merged commit a836b58 into ant-design:master Apr 20, 2021
@xrkffgg xrkffgg mentioned this pull request Apr 25, 2021
Merged
@haggen haggen mentioned this pull request Apr 27, 2021
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerm1it kerm1it kerm1it approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hello-chinese @kerm1it @yoyo837