Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Button with disabled and type="link" should not clickable #30209

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Apr 19, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #30207

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Button type="link" should not redirect when it is disabled.
🇨🇳 Chinese 修复 Button type="link" 添加 disabled 后仍然可点击跳转的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2021

@afc163 afc163 force-pushed the fix-button-link-disabled branch from b0a4157 to 2d4da3a Compare April 19, 2021 08:56
@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2021

Size Change: +44 B (0%)

Total Size: 829 kB

Filename Size Change
./dist/antd-with-locales.min.js 339 kB +28 B (0%)
./dist/antd.min.js 298 kB +16 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 63.8 kB 0 B
./dist/antd.dark.min.css 65 kB 0 B
./dist/antd.min.css 63.8 kB 0 B

compressed-size-action

@afc163 afc163 merged commit edb59bd into master Apr 19, 2021
@afc163 afc163 deleted the fix-button-link-disabled branch April 19, 2021 09:19
@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #30209 (49978e1) into master (48b7edc) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 49978e1 differs from pull request most recent head 2d4da3a. Consider uploading reports for the commit 2d4da3a to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #30209      +/-   ##
===========================================
+ Coverage   99.97%   100.00%   +0.02%     
===========================================
  Files         398       397       -1     
  Lines        7564      7524      -40     
  Branches     2127      2107      -20     
===========================================
- Hits         7562      7524      -38     
+ Misses          2         0       -2     
Impacted Files Coverage Δ
components/badge/index.tsx 100.00% <100.00%> (ø)
components/button/button.tsx 100.00% <100.00%> (ø)
components/space/Item.tsx 100.00% <0.00%> (ø)
components/page-header/index.tsx 100.00% <0.00%> (ø)
components/_util/hooks/useFlexGapSupport.ts
components/space/index.tsx 100.00% <0.00%> (+4.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48b7edc...2d4da3a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button 添加 href 被 disable 之后,依然可以跳转到新的 url
1 participant