Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): Update Typescript definition Upload #30188

Merged
merged 1 commit into from
Apr 18, 2021
Merged

fix(types): Update Typescript definition Upload #30188

merged 1 commit into from
Apr 18, 2021

Conversation

hello-chinese
Copy link
Contributor

@hello-chinese hello-chinese commented Apr 17, 2021 •
edited
Loading

LIST_IGNORE type is string

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Modify LIST_IGNORE field is of string type
🇨🇳 Chinese 修改LIST_IGNORE字段为string类型

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2021 •
edited
Loading

@codecov
Copy link

codecov bot commented Apr 17, 2021 •
edited
Loading

Codecov Report

Merging #30188 (bd1135c) into master (4b376d0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #30188   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines         7523      7523           
  Branches      2107      2107           
=========================================
  Hits          7523      7523
Impacted Files Coverage Δ
components/upload/Upload.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b376d0...bd1135c. Read the comment docs.

@xrkffgg xrkffgg merged commit 7be721b into ant-design:master Apr 18, 2021
@chenshuai2144 chenshuai2144 mentioned this pull request Apr 19, 2021
Merged
@kerm1it kerm1it mentioned this pull request Apr 20, 2021
Merged
19 tasks
@haggen
Copy link

haggen commented Apr 27, 2021 •
edited
Loading

This broke my use of the beforeUpload prop. I'm using it to fetch the actual upload URL and return either the File object or LIST_IGNORE but inside a promise (async function). According to the new type the LIST_IGNORE value can't be returned inside a promise. Putting in other words we can't decide to ignore the upload asynchronously.

I actually wanted to comment on #30213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrkffgg xrkffgg xrkffgg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hello-chinese @haggen @xrkffgg