Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upload): beforeUpload type declaration #29766

Merged
merged 2 commits into from
Mar 15, 2021
Merged

fix(upload): beforeUpload type declaration #29766

merged 2 commits into from
Mar 15, 2021

Conversation

kerm1it
Copy link
Member

@kerm1it kerm1it commented Mar 15, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#29474 (comment)

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Upload type declaration of beforeUpload
🇨🇳 Chinese 修复上传组件 beforeUpload 属性类型声明

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #29766 (a1b7b65) into master (6368b33) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #29766   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines         7510      7510           
  Branches      2112      2112           
=========================================
  Hits          7510      7510           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6368b33...a1b7b65. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2021

@kerm1it kerm1it requested a review from zombieJ March 15, 2021 07:42
@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2021

Size Change: 0 B

Total Size: 837 kB

ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 337 kB 0 B
./dist/antd.compact.min.css 67.2 kB 0 B
./dist/antd.dark.min.css 68.5 kB 0 B
./dist/antd.min.css 67.2 kB 0 B
./dist/antd.min.js 297 kB 0 B

compressed-size-action

@zombieJ zombieJ merged commit 7fdfa4e into master Mar 15, 2021
@zombieJ zombieJ deleted the fix-upload-ts branch March 15, 2021 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants