Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Internal upload list should always keep #29702

Merged
merged 1 commit into from
Mar 10, 2021
Merged

fix: Internal upload list should always keep #29702

merged 1 commit into from
Mar 10, 2021

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 10, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #29651

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Upload crash when fileList is null.
🇨🇳 Chinese 修复 Upload 当 fileList 为 null 时崩溃的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2021 •
edited
Loading

@codecov
Copy link

codecov bot commented Mar 10, 2021 •
edited
Loading

Codecov Report

Merging #29702 (787905d) into master (2d3c3a1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #29702   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          394       394           
  Lines         7519      7520    +1     
  Branches      2111      2112    +1     
=========================================
+ Hits          7519      7520    +1
Impacted Files Coverage Δ
components/upload/Upload.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d3c3a1...787905d. Read the comment docs.

@github-actions
Copy link
Contributor

Size Change: +57 B (0%)

Total Size: 837 kB

Filename Size Change
./dist/antd-with-locales.min.js 337 kB +22 B (0%)
./dist/antd.min.js 297 kB +35 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 67.2 kB 0 B
./dist/antd.dark.min.css 68.5 kB 0 B
./dist/antd.min.css 67.2 kB 0 B

compressed-size-action

@zombieJ zombieJ merged commit ca52def into master Mar 10, 2021
@zombieJ zombieJ deleted the fix-upload branch March 10, 2021 09:32
@chenshuai2144 chenshuai2144 mentioned this pull request Mar 14, 2021
Merged
This was referenced Mar 15, 2021
Merged
Closed
Closed
Closed
Merged
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Merged
This was referenced Mar 15, 2021
Closed
Closed
Merged
Closed
Closed
Merged
Closed
Merged
Merged
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Upload] 在 fileList 为 null 的时候，组件奔溃
1 participant
@zombieJ