Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Description full width #29630

Merged
merged 1 commit into from
Mar 5, 2021
Merged

fix: Description full width #29630

merged 1 commit into from
Mar 5, 2021

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 5, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

ref #25573

💡 Background and solution

云凤蝶侧反馈 Description 在 Table 下长度不全,看了一下历史是因为和 max-content 冲突。用 flex 来顶出 100% 宽度。

reproduce:
https://codesandbox.io/s/jibenyongfa-antd4130-forked-el0tt

📝 Changelog

Language Changelog
🇺🇸 English Fix Description under Table will not have 100% width.
🇨🇳 Chinese 修复 Description 在 Table 下没有 100% 宽度的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@zombieJ zombieJ requested a review from afc163 March 5, 2021 09:07
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2021

@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #29630 (69f31e1) into master (ef4b67d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #29630   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          394       394           
  Lines         7519      7519           
  Branches      2111      2111           
=========================================
  Hits          7519      7519           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef4b67d...ee35d37. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2021

Size Change: +49 B (0%)

Total Size: 837 kB

Filename Size Change
./dist/antd.compact.min.css 67.2 kB +18 B (0%)
./dist/antd.dark.min.css 68.5 kB +15 B (0%)
./dist/antd.min.css 67.2 kB +16 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 337 kB 0 B
./dist/antd.min.js 297 kB 0 B

compressed-size-action

@zombieJ zombieJ merged commit 55a63a6 into master Mar 5, 2021
@zombieJ zombieJ deleted the description-in-table branch March 5, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant