Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add onCancel and onEnd option for editable #29615

Merged
merged 4 commits into from
Mar 6, 2021

Conversation

jueinin
Copy link
Contributor

@jueinin jueinin commented Mar 4, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #29371

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Typography editable 新增 onCancelonEnd 回调。
🇨🇳 Chinese Typography editable supports onCancel and onEnd.

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2021

@yoyo837
Copy link
Contributor

yoyo837 commented Mar 4, 2021

请提交到feature分支

@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #29615 (9a9823f) into feature (1f7d200) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           feature    #29615   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          394       394           
  Lines         7483      7513   +30     
  Branches      2141      2111   -30     
=========================================
+ Hits          7483      7513   +30     
Impacted Files Coverage Δ
components/date-picker/locale/fa_IR.tsx 100.00% <ø> (ø)
components/form/FormItem.tsx 100.00% <ø> (ø)
components/form/FormItemInput.tsx 100.00% <ø> (ø)
components/grid/RowContext.tsx 100.00% <ø> (ø)
components/input/ClearableLabeledInput.tsx 100.00% <ø> (ø)
components/locale/fa_IR.tsx 100.00% <ø> (ø)
components/locale/ru_RU.tsx 100.00% <ø> (ø)
components/modal/ActionButton.tsx 100.00% <ø> (ø)
components/modal/ConfirmDialog.tsx 100.00% <ø> (ø)
components/slider/SliderTooltip.tsx 100.00% <ø> (ø)
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f7d200...45718e6. Read the comment docs.

@jueinin
Copy link
Contributor Author

jueinin commented Mar 4, 2021

好的 不好意思没注意

@jueinin jueinin changed the base branch from master to feature March 4, 2021 09:13
@jueinin jueinin changed the title feature: add onCancel and onEnd option for editable feat: add onCancel and onEnd option for editable Mar 5, 2021
@afc163 afc163 merged commit 24d1b3c into ant-design:feature Mar 6, 2021
chenshuai2144 added a commit that referenced this pull request Mar 13, 2021
* feat: add onCancel and onEnd option for editable (#29615)

* feature: add onCancel and onEnd option for editable

* doc: editable

* doc: add EN doc

* optimize: code

Co-authored-by: chenliang <chenliang9@xiaomi.com>

* feat: add parent class for different notification types (#29634)

close #29417

* refactor: Upload use origin behavior (#29737)

* refactor: Fallback of events

* test: Fix test case

* fix: Start file update logic

* fix: remove status update

* test: Remove wrapTest

* test: Fix test case

* chore: bump rc-upload

* docs: About desc

* feat: tab support moreIcon (#29744)

* feat: Tabs support moreIcon

* docs: Tabs support moreIcon

* style: lint

* docs: add english document

* Update components/tabs/index.zh-CN.md

Co-authored-by: xrkffgg <xrkffgg@vip.qq.com>

* Update components/tabs/index.en-US.md

Co-authored-by: xrkffgg <xrkffgg@vip.qq.com>

* Update components/tabs/index.zh-CN.md

* Update components/tabs/index.en-US.md

Co-authored-by: zty <zty.dev@outlook.com>
Co-authored-by: zty <zty.dev@icloud.com>
Co-authored-by: xrkffgg <xrkffgg@vip.qq.com>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: jueinin <1014397160@qq.com>
Co-authored-by: chenliang <chenliang9@xiaomi.com>
Co-authored-by: 不吃猫的鱼 <michael2ib1989@gmail.com>
Co-authored-by: 二货机器人 <smith3816@gmail.com>
Co-authored-by: Tianyuan Zhang <tianyuan233.zhang@gmail.com>
Co-authored-by: zty <zty.dev@outlook.com>
Co-authored-by: zty <zty.dev@icloud.com>
Co-authored-by: xrkffgg <xrkffgg@vip.qq.com>
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typography editable on cancel event
3 participants