Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Modal hooks update & destroy #29584

Merged
merged 3 commits into from
Mar 2, 2021
Merged

fix: Modal hooks update & destroy #29584

merged 3 commits into from
Mar 2, 2021

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 2, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #29441

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Modal with hooks call update or destroy not work before render.
🇨🇳 Chinese 修复 Modal 的 hooks 在渲染前调用 updatedestroy 无效的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2021

Prepare preview

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #29584 (65e2144) into master (79224ca) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #29584   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          393       393           
  Lines         7489      7502   +13     
  Branches      2109      2110    +1     
=========================================
+ Hits          7489      7502   +13     
Impacted Files Coverage Δ
components/modal/useModal/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79224ca...65e2144. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2021

Size Change: +261 B (0%)

Total Size: 836 kB

Filename Size Change
./dist/antd-with-locales.min.js 337 kB +141 B (0%)
./dist/antd.min.js 297 kB +120 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 67.1 kB 0 B
./dist/antd.dark.min.css 68.4 kB 0 B
./dist/antd.min.css 67.1 kB 0 B

compressed-size-action

@zombieJ zombieJ merged commit 992b99c into master Mar 2, 2021
@zombieJ zombieJ deleted the fix-modal-update branch March 2, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modal.update() doesn't work when called immediately after opening the modal via hook
1 participant