Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: message with prefixCls should not break #29574

Merged
merged 4 commits into from
Mar 2, 2021
Merged

fix: message with prefixCls should not break #29574

merged 4 commits into from
Mar 2, 2021

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 2, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix message.config with prefixCls missing enter and leave motion.
🇨🇳 Chinese 修复 message.config 配置 prefixCls 时丢失淡入淡出动画的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2021

Prepare preview

@codecov
Copy link

codecov bot commented Mar 2, 2021 •
edited
Loading

Codecov Report

Merging #29574 (0c4fb9c) into master (3fa2b48) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #29574   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          393       393           
  Lines         7477      7489   +12     
  Branches      2104      2109    +5     
=========================================
+ Hits          7477      7489   +12
Impacted Files Coverage Δ
components/config-provider/index.tsx 100.00% <100.00%> (ø)
components/message/index.tsx 100.00% <100.00%> (ø)
components/modal/confirm.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fa2b48...0c4fb9c. Read the comment docs.

@zombieJ
Copy link
Member Author

zombieJ commented Mar 2, 2021

cc @crazyair

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2021 •
edited
Loading

Size Change: +112 B (0%)

Total Size: 836 kB

Filename Size Change
./dist/antd-with-locales.min.js 337 kB +57 B (0%)
./dist/antd.min.js 296 kB +55 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 67.1 kB 0 B
./dist/antd.dark.min.css 68.4 kB 0 B
./dist/antd.min.css 67.1 kB 0 B

compressed-size-action

@crazyair
Copy link
Member

crazyair commented Mar 2, 2021

LGTM

@zombieJ zombieJ merged commit 2e5c848 into master Mar 2, 2021
@zombieJ zombieJ deleted the transitionName branch March 2, 2021 03:53
@afc163 afc163 mentioned this pull request Mar 6, 2021
Merged
This was referenced Mar 8, 2021
Merged
Closed
Merged
Closed
This was referenced Mar 15, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 17, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoyo837 yoyo837 yoyo837 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zombieJ @crazyair @yoyo837