Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: TextArea showCount should not be interactive #29245

Merged
merged 1 commit into from
Feb 5, 2021
Merged

fix: TextArea showCount should not be interactive #29245

merged 1 commit into from
Feb 5, 2021

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Feb 5, 2021 •
edited
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #29240

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix TextArea showCount should not be interactive.
🇨🇳 Chinese 修复 TextArea showCount 字数会遮挡 Form.Item extra 的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163 afc163 force-pushed the fix-textarea-count branch from 7d0781c to ef61d05 Compare February 5, 2021 07:57
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Feb 5, 2021 •
edited
Loading

@codecov
Copy link

codecov bot commented Feb 5, 2021 •
edited
Loading

Codecov Report

Merging #29245 (ef61d05) into master (cb2fc79) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #29245   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          394       394           
  Lines         7477      7477           
  Branches      2143      2143           
=========================================
  Hits          7477      7477

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb2fc79...ef61d05. Read the comment docs.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 5, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ef61d05:

Sandbox Source
antd reproduction template Configuration
antd reproduction template (forked) Issue #29240

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2021 •
edited
Loading

Size Change: -8 B (0%)

Total Size: 835 kB

Filename Size Change
./dist/antd.compact.min.css 67.1 kB -3 B (0%)
./dist/antd.dark.min.css 68.4 kB -3 B (0%)
./dist/antd.min.css 67.1 kB -2 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 336 kB 0 B
./dist/antd.min.js 296 kB 0 B

compressed-size-action

@afc163 afc163 merged commit a64056e into master Feb 5, 2021
@afc163 afc163 deleted the fix-textarea-count branch February 5, 2021 12:34
@dengfuping dengfuping mentioned this pull request Feb 9, 2021
Merged
@Cygra Cygra mentioned this pull request Mar 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

form.item 的extra 里面的内容 不可以点击
2 participants
@afc163 @ant-design-bot