Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: make Table expand icon same size as checkbox #29214

Merged
merged 1 commit into from
Feb 3, 2021
Merged

style: make Table expand icon same size as checkbox #29214

merged 1 commit into from
Feb 3, 2021

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Feb 3, 2021 •
edited
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #29207

💡 Background and solution

before after
图片

📝 Changelog

Language Changelog
🇺🇸 English Make Table expand icon and checkbox same size and aligned.
🇨🇳 Chinese 调整 Table 展开图标和选择框的大小一致并对齐。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Feb 3, 2021 •
edited
Loading

@afc163 afc163 force-pushed the fix-table-icon-size branch from 133901b to 7b468e6 Compare February 3, 2021 11:09
@codecov
Copy link

codecov bot commented Feb 3, 2021 •
edited
Loading

Codecov Report

Merging #29214 (7b468e6) into master (c1f5f19) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #29214   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          394       394           
  Lines         7478      7478           
  Branches      2134      2134           
=========================================
  Hits          7478      7478

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5097a8...7b468e6. Read the comment docs.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 3, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7b468e6:

Sandbox Source
antd reproduction template Configuration
selection - antd@4.12.0 (forked) Issue #29207

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2021

Size Change: +80 B (0%)

Total Size: 835 kB

Filename Size Change
./dist/antd.compact.min.css 67.1 kB +26 B (0%)
./dist/antd.dark.min.css 68.4 kB +28 B (0%)
./dist/antd.min.css 67.1 kB +26 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 336 kB 0 B
./dist/antd.min.js 296 kB 0 B

compressed-size-action

@afc163 afc163 merged commit f6683eb into master Feb 3, 2021
@afc163 afc163 deleted the fix-table-icon-size branch February 3, 2021 14:36
@zombieJ zombieJ mentioned this pull request Feb 4, 2021
Merged
15 tasks
@yoyo837 yoyo837 mentioned this pull request May 6, 2021
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expand and select table icons are wrongly sized (small table)
2 participants
@afc163 @ant-design-bot