Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Darken tag color #29144

Merged
merged 2 commits into from
Feb 1, 2021
Merged

chore: Darken tag color #29144

merged 2 commits into from
Feb 1, 2021

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Feb 1, 2021 •
edited by markdownify bot
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

image

📝 Changelog

Language Changelog
🇺🇸 English Darken Tag text color to enhance readability.
🇨🇳 Chinese 加深 Tag 文字颜色以提升可读性。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/tag/demo/colorful-inverse.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Feb 1, 2021 •
edited
Loading

@codecov
Copy link

codecov bot commented Feb 1, 2021 •
edited
Loading

Codecov Report

Merging #29144 (c27de6e) into master (a4aeafa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #29144   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          394       394           
  Lines         7484      7484           
  Branches      2140      2140           
=========================================
  Hits          7484      7484

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4aeafa...c27de6e. Read the comment docs.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 1, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c27de6e:

Sandbox Source
antd reproduction template Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2021

Size Change: +135 B (0%)

Total Size: 836 kB

Filename Size Change
./dist/antd.compact.min.css 67.2 kB +45 B (0%)
./dist/antd.dark.min.css 68.5 kB +45 B (0%)
./dist/antd.min.css 67.2 kB +45 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 336 kB 0 B
./dist/antd.min.js 296 kB 0 B

compressed-size-action

@zombieJ zombieJ merged commit 2b49bd4 into master Feb 1, 2021
@zombieJ zombieJ deleted the tag-color branch February 1, 2021 03:58
@afc163 afc163 mentioned this pull request Feb 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zombieJ @ant-design-bot