Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update Table ts definition #29084

Merged
merged 3 commits into from
Jan 27, 2021
Merged

chore: Update Table ts definition #29084

merged 3 commits into from
Jan 27, 2021

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jan 27, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Table ts definition update dataSource to readonly.
🇨🇳 Chinese Table ts 定义更新 dataSource 至 readonly。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jan 27, 2021 •
edited
Loading

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2021 •
edited
Loading

Size Change: 0 B

Total Size: 834 kB

ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 336 kB 0 B
./dist/antd.compact.min.css 66.9 kB 0 B
./dist/antd.dark.min.css 68.2 kB 0 B
./dist/antd.min.css 66.9 kB 0 B
./dist/antd.min.js 296 kB 0 B

compressed-size-action

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9e64c68:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jan 27, 2021 •
edited
Loading

Codecov Report

Merging #29084 (9e64c68) into master (0e95728) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #29084   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          393       393           
  Lines         7467      7467           
  Branches      2153      2153           
=========================================
  Hits          7467      7467
Impacted Files Coverage Δ
components/table/hooks/useSorter.tsx 100.00% <ø> (ø)
components/table/Table.tsx 100.00% <100.00%> (ø)
components/table/hooks/useLazyKVMap.ts 100.00% <100.00%> (ø)
components/table/util.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e95728...9e64c68. Read the comment docs.

@zombieJ zombieJ merged commit 08f25f0 into master Jan 27, 2021
@zombieJ zombieJ deleted the tbl-ts branch January 27, 2021 17:22
@zombieJ zombieJ mentioned this pull request Jan 28, 2021
Closed
19 tasks
@chenshuai2144 chenshuai2144 mentioned this pull request Jan 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zombieJ @ant-design-bot