Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: optimize calling sequence of onChange and onSelectAll in rowSelection of Table #29079

Merged
merged 4 commits into from
Jan 29, 2021
Merged

refactor: optimize calling sequence of onChange and onSelectAll in rowSelection of Table #29079

merged 4 commits into from
Jan 29, 2021

Conversation

kerm1it
Copy link
Member

@kerm1it kerm1it commented Jan 27, 2021 •
edited
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #28986

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Optimize Calling sequence of onChange and onSelectAll in rowSelection of Table.
🇨🇳 Chinese 优化表格 rowSelection 中 onChange 和 onSelectAll 的调用顺序。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jan 27, 2021 •
edited
Loading

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2021 •
edited
Loading

Size Change: +13 B (0%)

Total Size: 834 kB

Filename Size Change
./dist/antd-with-locales.min.js 336 kB +7 B (0%)
./dist/antd.min.js 296 kB +6 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 66.9 kB 0 B
./dist/antd.dark.min.css 68.2 kB 0 B
./dist/antd.min.css 66.9 kB 0 B

compressed-size-action

@kerm1it kerm1it force-pushed the fix-table-rowSelection branch from c881df9 to e1d1db1 Compare January 28, 2021 01:53
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 28, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 13e5e6b:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jan 28, 2021 •
edited
Loading

Codecov Report

Merging #29079 (13e5e6b) into master (86b149b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #29079   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          393       393           
  Lines         7473      7473           
  Branches      2151      2151           
=========================================
  Hits          7473      7473
Impacted Files Coverage Δ
components/table/hooks/useSelection.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86b149b...13e5e6b. Read the comment docs.

@kerm1it kerm1it changed the title chore: optimize calling sequence of onChange and onSelect in rowSelection of Table chore: optimize calling sequence of onChange and onSelectAll in rowSelection of Table Jan 28, 2021
@afc163
Copy link
Member

afc163 commented Jan 28, 2021

补一下用例。

@kerm1it kerm1it force-pushed the fix-table-rowSelection branch from 83bdcd2 to f0d9020 Compare January 28, 2021 12:30
@kerm1it kerm1it force-pushed the fix-table-rowSelection branch from f0d9020 to 13e5e6b Compare January 28, 2021 13:14
@kerm1it
Copy link
Member Author

kerm1it commented Jan 29, 2021

@afc163 测试加上了

@afc163 afc163 changed the title chore: optimize calling sequence of onChange and onSelectAll in rowSelection of Table refactor: optimize calling sequence of onChange and onSelectAll in rowSelection of Table Jan 29, 2021
@afc163 afc163 merged commit 47732b8 into master Jan 29, 2021
@afc163 afc163 deleted the fix-table-rowSelection branch January 29, 2021 05:22
@chenshuai2144 chenshuai2144 mentioned this pull request Jan 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

table.rowSelection里回调顺序
3 participants
@kerm1it @ant-design-bot @afc163