feat: Allow user to configure the Tooltip in the Table header #29002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit aaecc3a:
|
Codecov Report
@@ Coverage Diff @@
## feature #29002 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 393 393
Lines 7466 7467 +1
Branches 2152 2153 +1
=========================================
+ Hits 7466 7467 +1
Continue to review full report at Codecov.
|
|
Size Change: +184 B (0%) Total Size: 789 kB
|
afc163
reviewed
Jan 24, 2021
components/table/Table.tsx
Outdated
| @@ -96,6 +97,7 @@ export interface TableProps<RecordType> | |||
| }; | |||
| sortDirections?: SortOrder[]; | |||
| showSorterTooltip?: boolean; | |||
There was a problem hiding this comment.
showSorterTooltip={{ placement: 'top' }}There was a problem hiding this comment.
There was a problem hiding this comment.
I believe showSorterTooltip={{ ... }} is a better API.
showSorterTooltip: boolean | TooltipProps
harrisoff
changed the title
afc163
reviewed
Jan 25, 2021
afc163
reviewed
Jan 25, 2021
afc163
approved these changes
Jan 25, 2021
Co-authored-by: 偏右 <afc163@gmail.com>
afc163
reviewed
Jan 25, 2021
chenshuai2144
added a commit
that referenced
this pull request
Feb 1, 2021
* feat: Allow user to configure the Tooltip in the Table header (#29002) * feat: Table header supports tooltipPlacement * docs: add Table tooltipPlacement * feat: Allow user to configure the Tooltip in the Table header * fix: fix jsx and use old code style * fix: replace if blocks with ternary operator * docs: fix url Co-authored-by: 偏右 <afc163@gmail.com> * docs: fix url Co-authored-by: harrisoff <john@smith.kyon> Co-authored-by: 偏右 <afc163@gmail.com> * fix: Row with gutter has additional gap (#29059) * chore: init gutter * feat: col support gap * chore: Update playground * fix: Safari padding * test: fix test case * test: More test case * docs: Update demo * test: Update coverage * test: Update test hack * feat(input-number): add keyboard prop to support disable keyboard (#29110) Co-authored-by: Ant Design GitHub Bot <yesmeck+ant-design-bot@gmail.com> Co-authored-by: Harrison <stlebea@foxmail.com> Co-authored-by: harrisoff <john@smith.kyon> Co-authored-by: 偏右 <afc163@gmail.com> Co-authored-by: 二货机器人 <smith3816@gmail.com> Co-authored-by: Kermit <kermitlx@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
Currently there is no way to configure the Tooltip in the Table header.
📝 Changelog
☑️ Self Check before Merge
View rendered components/table/index.en-US.md
View rendered components/table/index.zh-CN.md