-
-
Notifications
You must be signed in to change notification settings - Fork 50.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Breadcrumb support breadcrumbRender #28999
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 99a12a8:
|
Codecov Report
@@ Coverage Diff @@
## feature #28999 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 393 393
Lines 7460 7465 +5
Branches 2089 2152 +63
=========================================
+ Hits 7460 7465 +5
Continue to review full report at Codecov.
|
Size Change: +31 B (0%) Total Size: 789 kB
ℹ️ View Unchanged
|
changelog 误导我,明明是 PageHeader 新增 breadcrumbRender 属性。 |
This feature conflicts with |
@chenshuai2144 @afc163 能让让 breadcrumb 渲染 jsx 吗?举个例子 我是想用展示 <PageHeader
breadcrumb = {<div>{id ?? name}</div>}
/> 数据刚刚拿到时候只有 id,然后根据 id 去请求得到 name。这些 data 都是随着每次 render 会变化的。 目前的话,只有 breadcrumb 属性变化了,才会重新渲染 breadcrumbRender |
应该不会的 breadcrumb 没做 memo,应该每次 render 都会执行一遍 |
@chenshuai2144 抱歉,我复现不出问题了 |
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge
View rendered components/page-header/index.en-US.md
View rendered components/page-header/index.zh-CN.md