style: add @progress-info-text-color #28981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrkffgg
changed the title
xrkffgg
changed the title
|
|
xrkffgg
reviewed
Jan 22, 2021
components/progress/style/index.less
Outdated
| @@ -93,7 +93,7 @@ | |||
| display: inline-block; | |||
| width: 2em; | |||
| margin-left: 8px; | |||
| color: @text-color-secondary; | |||
| color: @progress-text-color; | |||
There was a problem hiding this comment.
这个在circle里面用到了，是@text-color，两个互斥
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c13b9fa:
|
|
Size Change: +2.33 kB (0%) Total Size: 791 kB
|
Codecov Report
@@ Coverage Diff @@
## master #28981 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 393 394 +1
Lines 7450 7485 +35
Branches 2149 2141 -8
=========================================
+ Hits 7450 7485 +35
Continue to review full report at Codecov.
|
xrkffgg
reviewed
Jan 22, 2021
components/progress/style/index.less
Outdated
| @@ -163,7 +163,7 @@ | |||
| width: 100%; | |||
| margin: 0; | |||
| padding: 0; | |||
| color: @progress-text-color; | |||
| color: @progress-circle-text-color; | |||
|
QAQ |
xrkffgg
changed the title
afc163
reviewed
Feb 1, 2021
Co-authored-by: afc163 <afc163@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
fix #28980
💡 Background and solution
Fix issue: #28980
📝 Changelog
@progress-info-text-color☑️ Self Check before Merge
Not sure this change is appropriate. The Progress text color changed from
@text-secondary-colorto@text-color, which may cause visual difference.