-
-
Notifications
You must be signed in to change notification settings - Fork 50.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: exporting common types #28963
fix: exporting common types #28963
Conversation
Size Change: +15 B (0%) Total Size: 834 kB
ℹ️ View Unchanged
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1d1f5e5:
|
顺便支持了 import type 的 eslint 规则,以为包能小一点,没想到大了几 b |
建议先不动,不然有些 TS 没升上来会挂:#28819 |
好,我回滚掉 |
a046030
to
14366e7
Compare
ci 挂了,请检查。 |
Codecov Report
@@ Coverage Diff @@
## master #28963 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 393 393
Lines 7465 7466 +1
Branches 2152 2152
=========================================
+ Hits 7465 7466 +1
Continue to review full report at Codecov.
|
/rebase |
// jest.mock('react', () => ({ | ||
// ...jest.requireActual('react'), | ||
// useLayoutEffect: jest.requireActual('react').useEffect, | ||
// })); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
应该删掉。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个应该打开的,这样就没有 warning 了
不过执行顺序会有一点问题
2f75b0e
to
e693350
Compare
Co-authored-by: 偏右 <afc163@gmail.com>
export { default as Cascader } from './cascader'; | ||
|
||
export type { CheckboxProps, CheckboxOptionType } from './checkbox'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CheckboxChangeEvent应该也要导出
Radio 就有RadioChangeEvent导出
ColumnGroupType as TableColumnGroupType, | ||
ColumnType as TableColumnType, | ||
ColumnProps as TableColumnProps, | ||
} from './table'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ColumnsType 没有导出... 官网示例用的就是这个
import type { ColumnsType } from 'antd/es/table';
export { default as Comment } from './comment'; | ||
|
||
export { default as ConfigProvider } from './config-provider'; | ||
|
||
export type { DatePickerProps } from './date-picker'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
缺少 RangePickerProps 导出
[English Template / 英文模板]
🤔 这个变动的性质是?
🔗 相关 Issue
💡 需求背景和解决方案
📝 更新日志
☑️ 请求合并前的自查清单