fix: dont use document.body as slider's popup container #28865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when getPopupContainer is not defined, it should rely on rc-tooltip's default behavior instead of forcing it to use document.body
rinick
changed the title
|
|
|
Size Change: -13 B (0%) Total Size: 788 kB
ℹ️ View Unchanged
|
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4c94880:
|
|
@afc163 updated |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when getPopupContainer is not defined, it should rely on rc-tooltip's default behavior instead of forcing it to use document.body
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
#28435
💡 Background and solution
The Slider component shows tooltip in document.body by default. That means when slider is in a different document, like popup window or iframe, tooltip will be shown in the wrong location.
Solution:
Since this is already handled properly by rc-trigger and rc-tooltip, we only need to make sure slider doesn't override the default getPopupContainer behavior
📝 Changelog
☑️ Self Check before Merge