Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Typography ellipsis support tooltip #28821

Merged
merged 5 commits into from
Jan 12, 2021
Merged

feat: Typography ellipsis support tooltip #28821

merged 5 commits into from
Jan 12, 2021

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jan 12, 2021 •
edited by markdownify bot
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Typography ellipsis support tooltip to customize tooltip when ellipsis.
🇨🇳 Chinese Typography ellipsis 属性添加 tooltip 支持以自定义收缩时的提示信息。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/typography/demo/ellipsis.md
View rendered components/typography/index.en-US.md
View rendered components/typography/index.zh-CN.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jan 12, 2021 •
edited
Loading

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 12, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0a629cc:

Sandbox Source
antd reproduction template Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2021 •
edited
Loading

Size Change: +133 B (0%)

Total Size: 787 kB

Filename Size Change
./dist/antd-with-locales.min.js 312 kB +66 B (0%)
./dist/antd.min.js 273 kB +67 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 66.9 kB 0 B
./dist/antd.dark.min.css 68.1 kB 0 B
./dist/antd.min.css 66.9 kB 0 B

compressed-size-action

@zombieJ
Copy link
Member Author

zombieJ commented Jan 12, 2021

筒子们来个 approve 哇~

cc @ant-design/ant-design-collaborators

@zombieJ zombieJ merged commit a9bd809 into feature Jan 12, 2021
@zombieJ zombieJ deleted the tooltip branch January 12, 2021 08:47
afc163
afc163 reviewed Jan 14, 2021
View reviewed changes
components/typography/Text.tsx
}

return ellipsis;
}, [ellipsis]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ellipsis 是 literal object 的话，这个 useMemo 基本起不到作用。

@afc163 afc163 mentioned this pull request Jan 24, 2021
Merged
@ohhoney1 ohhoney1 mentioned this pull request Jan 25, 2021
Merged
19 tasks
@afc163 afc163 mentioned this pull request Jun 3, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerm1it kerm1it kerm1it left review comments

@hengkx hengkx hengkx approved these changes

@afc163 afc163 afc163 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zombieJ @ant-design-bot @afc163 @hengkx @kerm1it