Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(upload): support Error obj (message) #28716

Merged
merged 1 commit into from
Jan 15, 2021
Merged

feat(upload): support Error obj (message) #28716

merged 1 commit into from
Jan 15, 2021

Conversation

wangcch
Copy link
Contributor

@wangcch wangcch commented Jan 6, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

Support Error object. For customRequest

<Upload
  customRequest={(options) => {
    options.onError?.(new Error('error message'));
  }}
/>

Screen Shot 2021-01-06 at 2 14 34 PM

📝 Changelog

Language Changelog
🇺🇸 English Support for capturing Error message for the Upload error tooltip
🇨🇳 Chinese 支持 Upload 报错提示对 Error 文本信息的捕获（Tooltip）

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jan 6, 2021 •
edited
Loading

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2021

Size Change: +33 B (0%)

Total Size: 792 kB

Filename Size Change
./dist/antd-with-locales.min.js 314 kB +18 B (0%)
./dist/antd.min.js 276 kB +15 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 66.9 kB 0 B
./dist/antd.dark.min.css 68.1 kB 0 B
./dist/antd.min.css 66.9 kB 0 B

compressed-size-action

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 6, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 66e01fb:

Sandbox Source
antd reproduction template Configuration

@wangcch
Copy link
Contributor Author

wangcch commented Jan 6, 2021

https://codesandbox.io/s/antd-reproduction-template-forked-8gego?file=/index.js

@afc163 afc163 merged commit 97796a4 into ant-design:master Jan 15, 2021
@ycjcl868 ycjcl868 mentioned this pull request Jan 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrkffgg xrkffgg xrkffgg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wangcch @ant-design-bot @xrkffgg @afc163