Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: optimize card cover style #28624

Merged
merged 1 commit into from
Dec 31, 2020
Merged

style: optimize card cover style #28624

merged 1 commit into from
Dec 31, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Dec 31, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #28622

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Optimize the white border style of Card images.
🇨🇳 Chinese 优化 Card 图片白边样式。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@xrkffgg xrkffgg requested a review from afc163 December 31, 2020 05:01
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Dec 31, 2020 •
edited
Loading

@github-actions
Copy link
Contributor

Size Change: -2 B (0%)

Total Size: 793 kB

Filename Size Change
./dist/antd.compact.min.css 66.8 kB -1 B (0%)
./dist/antd.min.css 66.8 kB -1 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 315 kB 0 B
./dist/antd.dark.min.css 68 kB 0 B
./dist/antd.min.js 277 kB 0 B

compressed-size-action

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6a3200e:

Sandbox Source
antd reproduction template Configuration
delicate-wind-0prlo Issue #28622

@xrkffgg xrkffgg requested a review from zombieJ December 31, 2020 06:29
@zombieJ zombieJ merged commit 593df02 into master Dec 31, 2020
@zombieJ zombieJ deleted the card-css branch December 31, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 Awaiting requested review from afc163

@zombieJ zombieJ Awaiting requested review from zombieJ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Card 组件 cover 添加 video 展示的时候点击 controls 不会出现下载
3 participants
@xrkffgg @ant-design-bot @zombieJ