Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: desc support root level label & content style #28613

Merged
merged 1 commit into from
Dec 30, 2020
Merged

feat: desc support root level label & content style #28613

merged 1 commit into from
Dec 30, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Dec 30, 2020 •
edited
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Descriptions support labelStyle & contentStyle directly.
🇨🇳 Chinese Descriptions 上可以统一设置 labelStyle 和 contentStyle。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/descriptions/demo/style.md
View rendered components/descriptions/index.en-US.md
View rendered components/descriptions/index.zh-CN.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Dec 30, 2020 •
edited
Loading

@afc163
Copy link
Member

afc163 commented Dec 30, 2020

支持全局设置？

@zombieJ
Copy link
Member Author

zombieJ commented Dec 30, 2020

就是 Desc 上设置后，Item 不用设置。换个词儿？

@afc163
Copy link
Member

afc163 commented Dec 30, 2020

Descriptions 上可以统一设置 labelStyle 和 contentStyle

@afc163
Copy link
Member

afc163 commented Dec 30, 2020

labelWidth 需要么？

@github-actions
Copy link
Contributor

Size Change: +116 B (0%)

Total Size: 796 kB

Filename Size Change
./dist/antd-with-locales.min.js 316 kB +54 B (0%)
./dist/antd.min.js 278 kB +62 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 66.9 kB 0 B
./dist/antd.dark.min.css 68.2 kB 0 B
./dist/antd.min.css 66.9 kB 0 B

compressed-size-action

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9fd4f1a:

Sandbox Source
antd reproduction template Configuration

@zombieJ
Copy link
Member Author

zombieJ commented Dec 30, 2020 •
edited
Loading

labelWidth 需要么？

labelStyle 里可以写 width，不用额外添加了。

@afc163
Copy link
Member

afc163 commented Dec 30, 2020

云凤蝶那边用 labelStyle 方便不。

@zombieJ
Copy link
Member Author

zombieJ commented Dec 30, 2020 •
edited
Loading

云凤蝶那边用 labelStyle 方便不。

这个是基于之前云凤蝶需要的 Item.labelStyle 的拓展，之前表示让用户一个个设置太蛋疼。我 double confirm 一下。

确认过了，理解一致。可以合。

@zombieJ zombieJ merged commit a211756 into feature Dec 30, 2020
@zombieJ zombieJ deleted the root-desc branch December 30, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrkffgg xrkffgg xrkffgg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zombieJ @ant-design-bot @afc163 @xrkffgg