Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Select support responsive maxTagCount #28520

Merged
merged 11 commits into from
Dec 25, 2020
Merged

feat: Select support responsive maxTagCount #28520

merged 11 commits into from
Dec 25, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Dec 24, 2020 •
edited
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #28271

💡 Background and solution

  • 底层使用 rc-overflow 实现响应式
  • 部分样式抽成了 margin-inline-start|end 以移除 rtl 相关 less

预览 https://preview-28520-ant-design.surge.sh/components/select-cn/#components-select-demo-responsive

📝 Changelog

Language Changelog
🇺🇸 English Select maxTagCount support responsive in multiple mode.
🇨🇳 Chinese Select 多选模式下 maxTagCount 支持 responsive。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/select/demo/big-data.md
View rendered components/select/demo/responsive.md
View rendered components/select/index.en-US.md
View rendered components/select/index.zh-CN.md

@pr-triage pr-triage bot added the PR: draft label Dec 24, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Dec 24, 2020 •
edited
Loading

@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2020 •
edited
Loading

Size Change: -780 B (0%)

Total Size: 794 kB

Filename Size Change
./dist/antd-with-locales.min.js 315 kB -481 B (0%)
./dist/antd.compact.min.css 66.8 kB +61 B (0%)
./dist/antd.dark.min.css 68.1 kB +89 B (0%)
./dist/antd.min.css 66.8 kB +56 B (0%)
./dist/antd.min.js 277 kB -505 B (0%)

compressed-size-action

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 24, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3271cd5:

Sandbox Source
antd reproduction template Configuration

@afc163
Copy link
Member

afc163 commented Dec 24, 2020

体积炸了。

@zombieJ
Copy link
Member Author

zombieJ commented Dec 24, 2020

嗯，rc-select 发完正式版后，rc-tree-select 跟进。

@zombieJ zombieJ mentioned this pull request Dec 24, 2020
Merged
@zombieJ zombieJ marked this pull request as ready for review December 25, 2020 02:50
@zombieJ
Copy link
Member Author

zombieJ commented Dec 25, 2020

升级完后还是超了，rc-overflow gzip 后排出依赖本身代码 3KB，蛋疼。

@zombieJ
Copy link
Member Author

zombieJ commented Dec 25, 2020

align rc-resize-observer 后省了 0.5 KB。

@zombieJ
Copy link
Member Author

zombieJ commented Dec 25, 2020

rc-overflow 再压缩代码代码就要不好读了。不改了。

@afc163, sorry，俺又要把包大小调回来了 = =

@zombieJ zombieJ merged commit 6ecfa74 into feature Dec 25, 2020
@zombieJ zombieJ deleted the overflow branch December 25, 2020 05:13
@afc163
Copy link
Member

afc163 commented Dec 25, 2020

@zombieJ master 啥也没干，也超了 270 kB。

@zombieJ
Copy link
Member Author

zombieJ commented Dec 28, 2020

底层的 rc-resize-observer 版本问题，问了 @chenshuai2144 说是 0.x 的版本不会自动 bump。所以我统一升级到了 1.x 这个月发 minor 就回归了。

@zombieJ zombieJ mentioned this pull request Dec 31, 2020
Merged
19 tasks
@xrutayisire xrutayisire mentioned this pull request Jan 5, 2021
Closed
@petercat-assistant petercat-assistant bot mentioned this pull request Nov 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zombieJ @ant-design-bot @afc163