Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set title as not required property #28374

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Set title as not required property #28374

merged 1 commit into from
Dec 16, 2020

Conversation

zhukovvandrei
Copy link
Contributor

@zhukovvandrei zhukovvandrei commented Dec 15, 2020 •
edited
Loading

Why the title is required?

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@zhukovvandrei
Set title as not required property
3245396 
Why the title is required?
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Dec 15, 2020 •
edited
Loading

@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 789 kB

ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 313 kB 0 B
./dist/antd.compact.min.css 66.7 kB 0 B
./dist/antd.dark.min.css 68 kB 0 B
./dist/antd.min.css 66.7 kB 0 B
./dist/antd.min.js 275 kB 0 B

compressed-size-action

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3245396:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Dec 15, 2020 •
edited
Loading

Codecov Report

Merging #28374 (3245396) into master (76f724b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #28374   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          393       393           
  Lines         7388      7375   -13     
  Branches      2119      2121    +2     
=========================================
- Hits          7388      7375   -13
Impacted Files Coverage Δ
components/page-header/index.tsx 100.00% <ø> (ø)
components/card/Grid.tsx 100.00% <0.00%> (ø)
components/tree/Tree.tsx 100.00% <0.00%> (ø)
components/list/index.tsx 100.00% <0.00%> (ø)
components/affix/index.tsx 100.00% <0.00%> (ø)
components/alert/index.tsx 100.00% <0.00%> (ø)
components/badge/index.tsx 100.00% <0.00%> (ø)
components/steps/index.tsx 100.00% <0.00%> (ø)
components/table/Table.tsx 100.00% <0.00%> (ø)
components/slider/index.tsx 100.00% <0.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76f724b...3245396. Read the comment docs.

@afc163 afc163 merged commit 27df2d9 into ant-design:master Dec 16, 2020
vVvlife pushed a commit to vVvlife/ant-design that referenced this pull request Dec 18, 2020
@zhukovvandrei
fix: PageHeader title as not required property (ant-design#28374)
f59a613
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2021

  • 🚨 Please fill changelog in the PR

    • Write with a developer-oriented perspective and narrative method, without describing the details of the repair
    • Describing the problem and the impact on the developer
    • describing the user-first site problem, not your solution
    • Refer: https://ant.design/changelog#4.9.0

  • 🚨 请填写 PR 中的 changelog

    • 请用面向开发者的角度和叙述方式撰写，不描述修复细节
    • 描述问题和对开发者的影响
    • 描述用户第一现场的问题，而非你的解决方式
    • 参考：https://ant.design/changelog-cn#4.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhukovvandrei @ant-design-bot @afc163