Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix Tree node hover background of unselectable #28269

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Dec 9, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #28217

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Remove Tree hover background color when selectable={false}.
🇨🇳 Chinese 修复 Tree 当 selectable={false} 时节点依然有 hover 背景色的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163 afc163 requested a review from zombieJ as a code owner December 9, 2020 06:37
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Dec 9, 2020

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2020

Size Change: +85 B (0%)

Total Size: 789 kB

Filename Size Change
./dist/antd-with-locales.min.js 313 kB +17 B (0%)
./dist/antd.compact.min.css 66.7 kB +16 B (0%)
./dist/antd.dark.min.css 68 kB +17 B (0%)
./dist/antd.min.css 66.7 kB +17 B (0%)
./dist/antd.min.js 275 kB +18 B (0%)

compressed-size-action

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f3bb63e:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #28269 (f3bb63e) into master (bbdb345) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #28269   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          393       393           
  Lines         7389      7432   +43     
  Branches      2119      2129   +10     
=========================================
+ Hits          7389      7432   +43     
Impacted Files Coverage Δ
components/tree/Tree.tsx 100.00% <ø> (ø)
components/table/hooks/useFilter/index.tsx 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbdb345...f3bb63e. Read the comment docs.

@afc163 afc163 changed the title style: fix Tree node hover bg of unselectable style: fix Tree node hover background of unselectable Dec 9, 2020
@afc163 afc163 force-pushed the fix-tree-style branch 3 times, most recently from 2585c5a to 0cbdb8c Compare December 9, 2020 07:49
@afc163 afc163 merged commit b2a441c into master Dec 9, 2020
@afc163 afc163 deleted the fix-tree-style branch December 9, 2020 08:36
vouis pushed a commit to vouis/ant-design that referenced this pull request Dec 10, 2020
vouis pushed a commit to vouis/ant-design that referenced this pull request Dec 10, 2020
vVvlife pushed a commit to vVvlife/ant-design that referenced this pull request Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to disable hover in Tree (important when using custom rendering)
2 participants