Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Image add preview style #28235

Merged
merged 5 commits into from
Dec 7, 2020
Merged

feat: Image add preview style #28235

merged 5 commits into from
Dec 7, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Dec 7, 2020 •
edited by markdownify bot
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Image add preview style.
🇨🇳 Chinese Image 添加预览样式。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/image/demo/placeholder.md

@zombieJ zombieJ requested a review from rdmclin2 December 7, 2020 08:25
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Dec 7, 2020 •
edited
Loading

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2020 •
edited
Loading

Size Change: +426 B (0%)

Total Size: 791 kB

Filename Size Change
./dist/antd-with-locales.min.js 313 kB +135 B (0%)
./dist/antd.compact.min.css 66.7 kB +52 B (0%)
./dist/antd.dark.min.css 68 kB +54 B (0%)
./dist/antd.min.css 66.7 kB +51 B (0%)
./dist/antd.min.js 276 kB +134 B (0%)

compressed-size-action

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3f025ac:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Dec 7, 2020 •
edited
Loading

Codecov Report

Merging #28235 (3f025ac) into feature (f3ff21e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #28235   +/-   ##
========================================
  Coverage    99.98%   99.98%           
========================================
  Files          393      393           
  Lines         7391     7399    +8     
  Branches      2115     2119    +4     
========================================
+ Hits          7390     7398    +8     
  Misses           1        1
Impacted Files Coverage Δ
components/locale-provider/index.tsx 100.00% <ø> (ø)
components/locale/default.tsx 100.00% <ø> (ø)
components/locale/zh_CN.tsx 100.00% <ø> (ø)
components/image/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3ff21e...3f025ac. Read the comment docs.

rdmclin2
rdmclin2 approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@rdmclin2 rdmclin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zombieJ zombieJ merged commit 9cd4fab into feature Dec 7, 2020
@zombieJ zombieJ deleted the images branch December 7, 2020 09:08
vouis pushed a commit to vouis/ant-design that referenced this pull request Dec 10, 2020
@zombieJ @vouis
feat: Image add preview style (ant-design#28235)
0434ecf 
* feat: Add preview mask

* feat: Preview support locale

* test: Update snapshot

* fix lint

* fix lint
@shaodahong shaodahong mentioned this pull request Jan 3, 2021
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdmclin2 rdmclin2 rdmclin2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zombieJ @ant-design-bot @rdmclin2