Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: TextArea showCount style while using with Form #28130

Merged
merged 6 commits into from
Dec 2, 2020
Merged

fix: TextArea showCount style while using with Form #28130

merged 6 commits into from
Dec 2, 2020

Conversation

AlanCutFlim
Copy link
Contributor

@AlanCutFlim AlanCutFlim commented Dec 1, 2020 •
edited
Loading

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#28123

💡 Background and solution

Before:
image
After:
image

📝 Changelog

Language Changelog
🇺🇸 English Fix TextArea showCount style while using with Form
🇨🇳 Chinese 修复 TextArea 结合 Form 使用时的字数提示样式问题

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Dec 1, 2020 •
edited
Loading

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2020 •
edited
Loading

Size Change: +66 B (0%)

Total Size: 790 kB

Filename Size Change
./dist/antd.compact.min.css 66.7 kB +23 B (0%)
./dist/antd.dark.min.css 67.9 kB +21 B (0%)
./dist/antd.min.css 66.7 kB +22 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 313 kB 0 B
./dist/antd.min.js 275 kB 0 B

compressed-size-action

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 1, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2fd8750:

Sandbox Source
antd reproduction template Configuration

afc163
afc163 reviewed Dec 2, 2020
View reviewed changes
components/input/style/index.less Outdated
@@ -46,6 +46,9 @@

&-textarea {
&-show-count::after {
position: absolute;
right: 0;
bottom: -22px;
Copy link
Member

@afc163 afc163 Dec 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在 Form 中针对性修改吧，否则会有问题：

https://preview-28130-ant-design.surge.sh/components/input-cn/#components-input-demo-textarea-show-count

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@AlanCutFlim AlanCutFlim changed the title fix: TextArea showCount style while using Form validator fix: TextArea showCount style while combining with Form Dec 2, 2020
@AlanCutFlim AlanCutFlim changed the title fix: TextArea showCount style while combining with Form fix: TextArea showCount style while using with Form Dec 2, 2020
@AlanCutFlim AlanCutFlim requested a review from afc163 December 2, 2020 05:09
@AlanCutFlim
Copy link
Contributor Author

@afc163 请问 argos ci 里的错误是什么意思？
image

afc163
afc163 reviewed Dec 2, 2020
View reviewed changes
components/input/style/index.less Outdated
@@ -47,6 +47,7 @@
&-textarea {
&-show-count::after {
display: block;
width: 100%;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加这个的目的是？

Copy link
Contributor Author

@AlanCutFlim AlanCutFlim Dec 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加这个的目的是？

原来宽度是占满一行的，absolute 脱离文档流之后宽度就是内容的宽度了，此时就没有居右的效果了，宽度设为 100% 效果就和原来一样了。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果针对 absolute 的情况就放到 form 的样式去，不影响原来的样式。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@shaodahong
Copy link
Member

@afc163 请问 argos ci 里的错误是什么意思？

已修复，可以 rebase 下 master

@AlanCutFlim AlanCutFlim force-pushed the fix-textarea-validation branch from 78ade73 to 2fd8750 Compare December 2, 2020 06:04
@AlanCutFlim AlanCutFlim requested a review from afc163 December 2, 2020 06:24
@afc163 afc163 merged commit 6f0c657 into ant-design:master Dec 2, 2020
@afc163 afc163 mentioned this pull request Dec 2, 2020
Closed
1 task
marianayap added a commit to marianayap/ant-design that referenced this pull request Dec 2, 2020
@marianayap @jarretmoses
@hengkx @afc163 @jinliming2 @stygian-desolator @shaodahong @AlanCutFlim @TotooriaHyperion @Debiancc @kagawagao
Merge Changes (#1)
d9a512c 
* fix: update CarouselRef goTo args (ant-design#28090)

* chore: 🆙 upgrade react 17 (ant-design#27268)

ant-design#26136

* fix BUNDLESIZE_GITHUB_TOKEN

* docs: supplement Form.List errors (ant-design#28117)

* docs: set image preview false in placeholder demo (ant-design#28140)

* docs(📖): update v4 migration about less variables change

close ant-design#28141

* test: skip List loading demo (ant-design#28133)

* fix: TextArea showCount style while using with Form (ant-design#28130)

* chore: optimize useModal performance - Do not trigger rerender of parent component (ant-design#28122)

* fix: Add type of initialValue prop to Form.List (ant-design#28153)

* fix: Add type of initialValue prop to Form.List

* Update index.zh-CN.md

* Update index.en-US.md

* fix(Tree): fix tree drop indicator default direction (ant-design#28150)

Co-authored-by: Jarret Moses <jarret.moses@gmail.com>
Co-authored-by: Tom Xu <ycxzhkx@gmail.com>
Co-authored-by: afc163 <afc163@gmail.com>
Co-authored-by: Liming Jin <jinliming2@gmail.com>
Co-authored-by: stygian-desolator <73412177+stygian-desolator@users.noreply.github.com>
Co-authored-by: 骗你是小猫咪 <darryshaw@gmail.com>
Co-authored-by: einq7 <50612752+AlanCutFlim@users.noreply.github.com>
Co-authored-by: Elaina Cherudim <shr9192@gmail.com>
Co-authored-by: Debiancc <never.be.evil.debian@gmail.com>
Co-authored-by: Jingsong Gao <kingsongao1221@gmail.com>
@marianayap marianayap mentioned this pull request Dec 3, 2020
Closed
@ycjcl868 ycjcl868 mentioned this pull request Dec 6, 2020
Merged
@afc163 afc163 mentioned this pull request Mar 11, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 Awaiting requested review from afc163

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlanCutFlim @ant-design-bot @shaodahong @afc163