fix: Make dontAnimate optional in CarouselRef interface #28090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarretmoses
changed the title
jarretmoses
changed the title
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 06ebad1:
|
Codecov Report
@@ Coverage Diff @@
## master #28090 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 393 393
Lines 7371 7371
Branches 2112 2112
=========================================
Hits 7371 7371
Continue to review full report at Codecov.
|
jarretmoses
force-pushed
the
fix-carousel-ref
branch
from
7916cbe to
06ebad1
Compare
jarretmoses
changed the title
|
👍 |
marianayap
added a commit
to marianayap/ant-design
that referenced
this pull request
Dec 2, 2020
* fix: update CarouselRef goTo args (ant-design#28090) * chore: 🆙 upgrade react 17 (ant-design#27268) ant-design#26136 * fix BUNDLESIZE_GITHUB_TOKEN * docs: supplement Form.List errors (ant-design#28117) * docs: set image preview false in placeholder demo (ant-design#28140) * docs(📖): update v4 migration about less variables change close ant-design#28141 * test: skip List loading demo (ant-design#28133) * fix: TextArea showCount style while using with Form (ant-design#28130) * chore: optimize useModal performance - Do not trigger rerender of parent component (ant-design#28122) * fix: Add type of initialValue prop to Form.List (ant-design#28153) * fix: Add type of initialValue prop to Form.List * Update index.zh-CN.md * Update index.en-US.md * fix(Tree): fix tree drop indicator default direction (ant-design#28150) Co-authored-by: Jarret Moses <jarret.moses@gmail.com> Co-authored-by: Tom Xu <ycxzhkx@gmail.com> Co-authored-by: afc163 <afc163@gmail.com> Co-authored-by: Liming Jin <jinliming2@gmail.com> Co-authored-by: stygian-desolator <73412177+stygian-desolator@users.noreply.github.com> Co-authored-by: 骗你是小猫咪 <darryshaw@gmail.com> Co-authored-by: einq7 <50612752+AlanCutFlim@users.noreply.github.com> Co-authored-by: Elaina Cherudim <shr9192@gmail.com> Co-authored-by: Debiancc <never.be.evil.debian@gmail.com> Co-authored-by: Jingsong Gao <kingsongao1221@gmail.com>
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
v4.8.6 introduced a new CarouselRef type which is great but it did not correctly allow the
dontAnimateargument of thegoTomethod to be optional which according to the source code it is. This just makes the argument optional.📝 Changelog
☑️ Self Check before Merge